Re: [PATCH 1/2][v3] powerpc/fsl-booke: Add initial T104x_QDS board support

2013-09-24 Thread Timur Tabi
Scott Wood wrote: >I think it should be okay to leave the DIU node. I think the kernel >will crash if you try to enable a DIU console (video= on the kernel >command line), but I think it's okay to ignore that for the moment. Sounds like a bug in the DIU driver. It should fail gracefully in t

Re: [PATCH 1/2][v3] powerpc/fsl-booke: Add initial T104x_QDS board support

2013-09-24 Thread Scott Wood
On Thu, 2013-09-19 at 22:08 -0500, Timur Tabi wrote: > Kushwaha Prabhakar-B32579 wrote: > > My primary object is to put base patch in Linux. once it done other things > > can be enabled one by one. > > Any features which are not enabled must be specified in the patch > description. The patch sa

Re: [PATCH 1/2][v3] powerpc/fsl-booke: Add initial T104x_QDS board support

2013-09-23 Thread Scott Wood
On Fri, 2013-09-20 at 19:23 -0500, Timur Tabi wrote: > Scott Wood wrote: > > The patch is not "lying". It is describing the board, not what the > > patch supports. This was something you used to constantly tell people > > to do... > > The patch says: > > "DIU supports video at up to 1280x

Re: [PATCH 1/2][v3] powerpc/fsl-booke: Add initial T104x_QDS board support

2013-09-20 Thread Timur Tabi
Scott Wood wrote: The patch is not "lying". It is describing the board, not what the patch supports. This was something you used to constantly tell people to do... The patch says: "DIU supports video at up to 1280x1024x32bpp" How is this not misleading? I understand that the patch

Re: [PATCH 1/2][v3] powerpc/fsl-booke: Add initial T104x_QDS board support

2013-09-20 Thread Scott Wood
@lists.ozlabs.org; Wood Scott-B07421; Jain Priyanka- > > B32167; Aggrwal Poonam-B10812 > > Subject: Re: [PATCH 1/2][v3] powerpc/fsl-booke: Add initial T104x_QDS > > board support > > > > On Thu, Sep 19, 2013 at 4:00 AM, Prabhakar Kushwaha > > wrote: > > > &

Re: [PATCH 1/2][v3] powerpc/fsl-booke: Add initial T104x_QDS board support

2013-09-20 Thread Scott Wood
On Fri, 2013-09-20 at 06:55 -0500, Timur Tabi wrote: > Prabhakar Kushwaha wrote: > > > > I think patch set is OK for now. No need to send v4. > > It needs an updated patch description because the patch lies. It > advertises DIU support, which is not true. The patch is not "lying". It is descri

Re: [PATCH 1/2][v3] powerpc/fsl-booke: Add initial T104x_QDS board support

2013-09-20 Thread Timur Tabi
Prabhakar Kushwaha wrote: I think patch set is OK for now. No need to send v4. It needs an updated patch description because the patch lies. It advertises DIU support, which is not true. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org

Re: [PATCH 1/2][v3] powerpc/fsl-booke: Add initial T104x_QDS board support

2013-09-20 Thread Prabhakar Kushwaha
On 09/20/2013 08:38 AM, Timur Tabi wrote: Kushwaha Prabhakar-B32579 wrote: My primary object is to put base patch in Linux. once it done other things can be enabled one by one. Any features which are not enabled must be specified in the patch description. The patch says that the board suppor

Re: [PATCH 1/2][v3] powerpc/fsl-booke: Add initial T104x_QDS board support

2013-09-19 Thread Timur Tabi
Kushwaha Prabhakar-B32579 wrote: My primary object is to put base patch in Linux. once it done other things can be enabled one by one. Any features which are not enabled must be specified in the patch description. The patch says that the board supports DIU, but the code doesn't, so that's m

RE: [PATCH 1/2][v3] powerpc/fsl-booke: Add initial T104x_QDS board support

2013-09-19 Thread Kushwaha Prabhakar-B32579
ATCH 1/2][v3] powerpc/fsl-booke: Add initial T104x_QDS > board support > > On Thu, Sep 19, 2013 at 4:00 AM, Prabhakar Kushwaha > wrote: > > > - Video > > - DIU supports video at up to 1280x1024x32bpp > > You mention DIU support, except there's no

Re: [PATCH 1/2][v3] powerpc/fsl-booke: Add initial T104x_QDS board support

2013-09-19 Thread Timur Tabi
On Thu, Sep 19, 2013 at 4:00 AM, Prabhakar Kushwaha wrote: > - Video > - DIU supports video at up to 1280x1024x32bpp You mention DIU support, except there's no DIU enablement in the platform file. You need the T104x equivalent of p1022ds_set_pixel_clock() and the other functions.

[PATCH 1/2][v3] powerpc/fsl-booke: Add initial T104x_QDS board support

2013-09-19 Thread Prabhakar Kushwaha
Add support for T104x board in board file t104x_qds.c, It is common for both T1040 and T1042 as they share same QDS board. T1040QDS board Overview --- - SERDES Connections, 8 lanes supporting: — PCI Express: supporting Gen 1 and Gen 2; — SGMII — QSGMII