Re: [PATCH 1/2][v2] Integrated Flash Controller support

2012-01-02 Thread Scott Wood
On 12/28/2011 07:30 AM, dmitry pervushin wrote: > If you're using memory-mapped structure, shouldn't it be announced with > __attribute__(packed) ? Why? We know this isn't going to be compiled on some strange ABI where a struct with nothing but u32 gets padding. __attribute__((packed)) also tell

Re: [PATCH 1/2][v2] Integrated Flash Controller support

2011-12-28 Thread dmitry pervushin
On Tue, 2011-12-27 at 17:39 +0530, Prabhakar Kushwaha wrote: [...] > +/* > + * IFC Controller NAND Machine registers > + */ > +struct fsl_ifc_nand { > + __be32 ncfgr; > + u32 res1[0x4]; > + __be32 nand_fcr0; > + __be32 nand_fcr1; > + u32 res2[0x8]; > + __be32 row0; > + u

[PATCH 1/2][v2] Integrated Flash Controller support

2011-12-27 Thread Prabhakar Kushwaha
Integrated Flash Controller supports various flashes like NOR, NAND and other devices using NOR, NAND and GPCM Machine available on it. IFC supports four chip selects. Signed-off-by: Dipen Dudhat Signed-off-by: Scott Wood Signed-off-by: Li Yang Signed-off-by: Liu Shuo Signed-off-by: Prabhakar

[PATCH 1/2][v2] Integrated Flash Controller support

2011-12-27 Thread Prabhakar Kushwaha
Integrated Flash Controller supports various flashes like NOR, NAND and other devices using NOR, NAND and GPCM Machine available on it. IFC supports four chip selects. Signed-off-by: Dipen Dudhat Signed-off-by: Scott Wood Signed-off-by: Li Yang Signed-off-by: Liu Shuo Signed-off-by: Prabhakar