Re: [PATCH 1/1] powerpc/85xx: Board support for ppa8548

2013-02-04 Thread Scott Wood
On 02/01/2013 10:34:44 PM, Timur Tabi wrote: On Fri, Feb 1, 2013 at 6:31 PM, Scott Wood wrote: > > I guess the reason you're not using fsl/mpc8548si-post.dtsi is that you > don't want PCI. Maybe PCI and srio should be moved out of that file, or > ifdeffed if 85xx ever ends up using the pr

Re: [PATCH 1/1] powerpc/85xx: Board support for ppa8548

2013-02-02 Thread Timur Tabi
On Sat, Feb 2, 2013 at 1:25 PM, Stef van Os wrote: >> I guess the reason you're not using fsl/mpc8548si-post.dtsi is that you >> don't want PCI. Maybe PCI and srio should be moved out of that file, or >> ifdeffed if 85xx ever ends up using the preprocessor for its device trees. >> > I went with

Re: [PATCH 1/1] powerpc/85xx: Board support for ppa8548

2013-02-02 Thread Stef van Os
Thanks for the comment! On 02/02/2013 01:31 AM, Scott Wood wrote: On 02/01/2013 09:36:53 AM, Stef van Os wrote: +memory { +device_type = "memory"; +reg = <0 0 0x0 0x4000>; +}; You have a "filled in by U-Boot" comment elsewhere in the file, but you aren't letting U

Re: [PATCH 1/1] powerpc/85xx: Board support for ppa8548

2013-02-01 Thread Timur Tabi
On Fri, Feb 1, 2013 at 6:31 PM, Scott Wood wrote: > > I guess the reason you're not using fsl/mpc8548si-post.dtsi is that you > don't want PCI. Maybe PCI and srio should be moved out of that file, or > ifdeffed if 85xx ever ends up using the preprocessor for its device trees. Wouldn't it be easi

Re: [PATCH 1/1] powerpc/85xx: Board support for ppa8548

2013-02-01 Thread Scott Wood
On 02/01/2013 09:36:53 AM, Stef van Os wrote: + memory { + device_type = "memory"; + reg = <0 0 0x0 0x4000>; + }; You have a "filled in by U-Boot" comment elsewhere in the file, but you aren't letting U-Boot fill in the memory size? + board

[PATCH 1/1] powerpc/85xx: Board support for ppa8548

2013-02-01 Thread Stef van Os
Initial board support for the Prodrive PPA8548 AMC module. Board is an MPC8548 AMC platform used in RapidIO systems. This module is also used to test/work on mainline linux RapidIO software. PPA8548 overview: - 1.3 GHz Freescale PowerQUICC III MPC8548 processor - 1 GB DDR2 @ 266 MHz - 8 MB NOR fla