Re: [PATCH 1/1] carma-fpga: fix race between data dumping and DMA callback

2012-01-27 Thread Ira W. Snyder
On Fri, Jan 27, 2012 at 08:25:37AM +1100, Benjamin Herrenschmidt wrote: > On Thu, 2012-01-26 at 13:00 -0800, Ira W. Snyder wrote: > > > > @@ -970,7 +984,13 @@ static ssize_t data_en_show(struct device *dev, struct > > device_attribute *attr, > > char *buf) > > { > >

Re: [PATCH 1/1] carma-fpga: fix race between data dumping and DMA callback

2012-01-26 Thread Benjamin Herrenschmidt
On Thu, 2012-01-26 at 13:00 -0800, Ira W. Snyder wrote: > > @@ -970,7 +984,13 @@ static ssize_t data_en_show(struct device *dev, struct > device_attribute *attr, > char *buf) > { > struct fpga_device *priv = dev_get_drvdata(dev); > - return snprintf(buf,

[PATCH 1/1] carma-fpga: fix race between data dumping and DMA callback

2012-01-26 Thread Ira W. Snyder
When the system is under heavy load, we occasionally saw a problem where the system would get a legitimate interrupt when they should be disabled. This was caused by the data_dma_cb() DMA callback unconditionally re-enabling FPGA interrupts even when data dumping is disabled. When data dumping was