Re: [PATCH 09/15] sh: rework sync_file_range ABI

2024-06-24 Thread Arnd Bergmann
On Mon, Jun 24, 2024, at 08:14, John Paul Adrian Glaubitz wrote: > On Fri, 2024-06-21 at 11:41 +0200, Arnd Bergmann wrote: >> On Fri, Jun 21, 2024, at 10:44, John Paul Adrian Glaubitz wrote: >> > Did you also check what order libc uses? I would expect libc on SuperH >> > misordering the >> > argum

Re: [PATCH 09/15] sh: rework sync_file_range ABI

2024-06-23 Thread John Paul Adrian Glaubitz
Hi Arnd, On Fri, 2024-06-21 at 11:41 +0200, Arnd Bergmann wrote: > On Fri, Jun 21, 2024, at 10:44, John Paul Adrian Glaubitz wrote: > > On Thu, 2024-06-20 at 18:23 +0200, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > > > The unusual function calling conventions on superh ended up causin

Re: [musl] Re: [PATCH 09/15] sh: rework sync_file_range ABI

2024-06-21 Thread Rich Felker
On Fri, Jun 21, 2024 at 10:44:39AM +0200, John Paul Adrian Glaubitz wrote: > Hi Arnd, > > thanks for your patch! > > On Thu, 2024-06-20 at 18:23 +0200, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > The unusual function calling conventions on superh ended up causing >

Re: [PATCH 09/15] sh: rework sync_file_range ABI

2024-06-21 Thread Arnd Bergmann
On Fri, Jun 21, 2024, at 10:44, John Paul Adrian Glaubitz wrote: > On Thu, 2024-06-20 at 18:23 +0200, Arnd Bergmann wrote: >> From: Arnd Bergmann >> >> The unusual function calling conventions on superh ended up causing > ^^ >

Re: [PATCH 09/15] sh: rework sync_file_range ABI

2024-06-21 Thread John Paul Adrian Glaubitz
Hi Arnd, thanks for your patch! On Thu, 2024-06-20 at 18:23 +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > The unusual function calling conventions on superh ended up causing ^^ It's spelled SuperH

[PATCH 09/15] sh: rework sync_file_range ABI

2024-06-20 Thread Arnd Bergmann
From: Arnd Bergmann The unusual function calling conventions on superh ended up causing sync_file_range to have the wrong argument order, with the 'flags' argument getting sorted before 'nbytes' by the compiler. In userspace, I found that musl, glibc, uclibc and strace all expect the normal call