Re: [PATCH 08/12] ptp: Added a brand new class driver for ptp clocks.

2010-08-13 Thread Grant Likely
On Fri, Aug 13, 2010 at 3:34 AM, Richard Cochran wrote: > On Tue, Jun 15, 2010 at 01:11:30PM -0600, Grant Likely wrote: >> On Tue, Jun 15, 2010 at 10:09 AM, Richard Cochran >> > +static DEFINE_SPINLOCK(clocks_lock); /* protects 'clocks' */ >> >> Doesn't appear that clocks is manipulated at atomic

Re: [PATCH 08/12] ptp: Added a brand new class driver for ptp clocks.

2010-08-13 Thread Richard Cochran
On Tue, Jun 15, 2010 at 01:11:30PM -0600, Grant Likely wrote: > On Tue, Jun 15, 2010 at 10:09 AM, Richard Cochran > > +static DEFINE_SPINLOCK(clocks_lock); /* protects 'clocks' */ > > Doesn't appear that clocks is manipulated at atomic context. Mutex instead? ... > If the spinlock is changed to a

Re: [PATCH 08/12] ptp: Added a brand new class driver for ptp clocks.

2010-06-16 Thread Richard Cochran
On Tue, Jun 15, 2010 at 11:00:10AM -0600, Grant Likely wrote: > > Question from an ignorant reviewer: Why a new interface instead of > working with the existing high resolution timers infrastructure? Short answer: Timers are only one part of the PTP API. If you offer the PTP clock as a Linux clo

Re: [PATCH 08/12] ptp: Added a brand new class driver for ptp clocks.

2010-06-15 Thread Grant Likely
On Tue, Jun 15, 2010 at 10:09 AM, Richard Cochran wrote: > This patch adds an infrastructure for hardware clocks that implement > IEEE 1588, the Precision Time Protocol (PTP). A class driver offers a > registration method to particular hardware clock drivers. Each clock is > exposed to user space

Re: [PATCH 08/12] ptp: Added a brand new class driver for ptp clocks.

2010-06-15 Thread Grant Likely
On Tue, Jun 15, 2010 at 10:09 AM, Richard Cochran wrote: > This patch adds an infrastructure for hardware clocks that implement > IEEE 1588, the Precision Time Protocol (PTP). A class driver offers a > registration method to particular hardware clock drivers. Each clock is > exposed to user space

[PATCH 08/12] ptp: Added a brand new class driver for ptp clocks.

2010-06-15 Thread Richard Cochran
This patch adds an infrastructure for hardware clocks that implement IEEE 1588, the Precision Time Protocol (PTP). A class driver offers a registration method to particular hardware clock drivers. Each clock is exposed to user space as a character device with ioctls that allow tuning of the PTP clo