Re: [PATCH 08/12] fsl/fman: Add Frame Manager support

2015-06-15 Thread Scott Wood
On Mon, 2015-06-15 at 23:42 -0400, Bob Cochran wrote: > On 06/10/2015 11:21 AM, Madalin Bucur wrote: > > > > +#define FM_QMI_NO_ECC_EXCEPTIONS /* P1 */ > > +#define FM_CSI_CFED_LIMIT /* P1 */ > > +#define FM_PEDANTIC_DMA/* P1 */ > > +#define F

Re: [PATCH 08/12] fsl/fman: Add Frame Manager support

2015-06-15 Thread Bob Cochran
On 06/10/2015 11:21 AM, Madalin Bucur wrote: From: Igal Liberman Add Frame Manger Driver support. This patch adds The FMan configuration, initialization and runtime control routines. Signed-off-by: Igal Liberman --- drivers/net/ethernet/freescale/fman/Kconfig| 37 + drivers/net/e

RE: [PATCH 08/12] fsl/fman: Add Frame Manager support

2015-06-15 Thread Liberman Igal
Bucur Madalin-Cristian-B32716 > Cc: net...@vger.kernel.org; linux-ker...@vger.kernel.org; linuxppc- > d...@lists.ozlabs.org; Wood Scott-B07421; Liberman Igal-B31950 > Subject: Re: [PATCH 08/12] fsl/fman: Add Frame Manager support > > So I couldn't help having yet another look

Re: [PATCH 08/12] fsl/fman: Add Frame Manager support

2015-06-11 Thread Paul Bolle
So I couldn't help having yet another look at the code, just to drive home my point. On Thu, 2015-06-11 at 10:55 +0200, Paul Bolle wrote: > > +void *fm_drv_init(void) > > static. > > > +{ > > + memset(&fm_drvs, 0, sizeof(fm_drvs)); fm_drvs is an external variable. It is guaranteed to be zero,

Re: [PATCH 08/12] fsl/fman: Add Frame Manager support

2015-06-11 Thread Paul Bolle
You should note that I started with scanning this patch for basic, say, build system issues. Which I did find. But then I kept spotting all kind of oddities. After a while I stopped looking closely. So, to note something, I haven't yet looked into the 24 symbols this series exports. There might be