Re: [PATCH 07/11] of: merge machine_is_compatible()

2009-12-10 Thread Grant Likely
On Wed, Nov 25, 2009 at 9:05 PM, Benjamin Herrenschmidt wrote: > On Tue, 2009-11-24 at 01:19 -0700, Grant Likely wrote: >> Merge common code between PowerPC and Microblaze > > I don't like moving this one to common code without the of_ prefix. I > think you should move it with the of_ prefix, and

Re: [PATCH 07/11] of: merge machine_is_compatible()

2009-11-25 Thread Benjamin Herrenschmidt
On Tue, 2009-11-24 at 01:19 -0700, Grant Likely wrote: > Merge common code between PowerPC and Microblaze I don't like moving this one to common code without the of_ prefix. I think you should move it with the of_ prefix, and then add a alias in powerpc and microblaze without of_ in a header until

[PATCH 07/11] of: merge machine_is_compatible()

2009-11-24 Thread Grant Likely
Merge common code between PowerPC and Microblaze Signed-off-by: Grant Likely --- arch/microblaze/kernel/prom.c | 18 -- arch/powerpc/kernel/prom.c| 18 -- drivers/of/base.c | 18 ++ 3 files changed, 18 insertions(+), 36 delet