Re: [PATCH 07/10] um: Should hold tasklist_lock while traversing processes

2012-03-24 Thread Anton Vorontsov
On Sat, Mar 24, 2012 at 01:48:23PM +0100, Peter Zijlstra wrote: > On Sat, 2012-03-24 at 14:30 +0400, Anton Vorontsov wrote: > > Traversing the tasks requires holding tasklist_lock, otherwise it > > is unsafe. > > No it doesn't, it either requires tasklist_lock or rcu_read_lock(). Well, currently

[PATCH 07/10] um: Should hold tasklist_lock while traversing processes

2012-03-24 Thread Anton Vorontsov
Traversing the tasks requires holding tasklist_lock, otherwise it is unsafe. p.s. However, I'm not sure that calling os_kill_ptraced_process() in the atomic context is correct. It seem to work, but please take a closer look. Signed-off-by: Anton Vorontsov --- arch/um/kernel/reboot.c |3 +++

Re: [PATCH 07/10] um: Should hold tasklist_lock while traversing processes

2012-03-24 Thread Peter Zijlstra
On Sat, 2012-03-24 at 14:30 +0400, Anton Vorontsov wrote: > Traversing the tasks requires holding tasklist_lock, otherwise it > is unsafe. No it doesn't, it either requires tasklist_lock or rcu_read_lock(). ___ Linuxppc-dev mailing list Linuxppc-dev@lis

Re: [PATCH 07/10] um: Should hold tasklist_lock while traversing processes

2012-03-24 Thread Richard Weinberger
Am 24.03.2012 11:30, schrieb Anton Vorontsov: > Traversing the tasks requires holding tasklist_lock, otherwise it > is unsafe. > > p.s. However, I'm not sure that calling os_kill_ptraced_process() > in the atomic context is correct. It seem to work, but please > take a closer look. os_kill_ptrace