Re: [PATCH 06/18] spufs: use llseek in all file operations

2010-07-08 Thread Arnd Bergmann
On Thursday 08 July 2010, Jeremy Kerr wrote: > > @@ -2151,7 +2166,7 @@ static ssize_t spufs_ibox_info_read(struct file > > *file, char __user *buf, > > static const struct file_operations spufs_ibox_info_fops = { > > .open = spufs_info_open, > > .read = spufs_ibox_info_read, > > -

Re: [PATCH 06/18] spufs: use llseek in all file operations

2010-07-07 Thread Jeremy Kerr
Hi Arnd, > The default for llseek is changing, so we need > explicit operations everywhere. Looks good, but: > @@ -2151,7 +2166,7 @@ static ssize_t spufs_ibox_info_read(struct file *file, > char __user *buf, > static const struct file_operations spufs_ibox_info_fops = { > .open = spufs_i

[PATCH 06/18] spufs: use llseek in all file operations

2010-07-07 Thread Arnd Bergmann
The default for llseek is changing, so we need explicit operations everywhere. Signed-off-by: Arnd Bergmann Cc: Jeremy Kerr Cc: linuxppc-...@ozlabs.org --- arch/powerpc/platforms/cell/spufs/file.c | 24 +--- 1 files changed, 21 insertions(+), 3 deletions(-) diff --git a/a