RE: [PATCH 06/12] openrisc: Use of_get_cpu_hwid()

2021-10-07 Thread David Laight
From: Segher Boessenkool > Sent: 06 October 2021 22:27 > > On Thu, Oct 07, 2021 at 05:44:00AM +0900, Stafford Horne wrote: > > You have defined of_get_cpu_hwid to return u64, will this create compiler > > warnings when since we are storing a u64 into a u32? > > > > It seems only if we make with W=

Re: [PATCH 06/12] openrisc: Use of_get_cpu_hwid()

2021-10-06 Thread Stafford Horne
Hi Segher, On Wed, Oct 06, 2021 at 04:27:28PM -0500, Segher Boessenkool wrote: > On Thu, Oct 07, 2021 at 05:44:00AM +0900, Stafford Horne wrote: > > You have defined of_get_cpu_hwid to return u64, will this create compiler > > warnings when since we are storing a u64 into a u32? > > > > It seems

Re: [PATCH 06/12] openrisc: Use of_get_cpu_hwid()

2021-10-06 Thread Segher Boessenkool
On Thu, Oct 07, 2021 at 05:44:00AM +0900, Stafford Horne wrote: > You have defined of_get_cpu_hwid to return u64, will this create compiler > warnings when since we are storing a u64 into a u32? > > It seems only if we make with W=3. Yes. This is done by -Wconversion, "Warn for implicit conversi

Re: [PATCH 06/12] openrisc: Use of_get_cpu_hwid()

2021-10-06 Thread Stafford Horne
On Wed, Oct 06, 2021 at 04:08:38PM -0500, Rob Herring wrote: > On Wed, Oct 6, 2021 at 3:44 PM Stafford Horne wrote: > > > > On Wed, Oct 06, 2021 at 11:43:26AM -0500, Rob Herring wrote: > > > Replace open coded parsing of CPU nodes' 'reg' property with > > > of_get_cpu_hwid(). > > > > > > Cc: Jonas

Re: [PATCH 06/12] openrisc: Use of_get_cpu_hwid()

2021-10-06 Thread Rob Herring
On Wed, Oct 6, 2021 at 3:44 PM Stafford Horne wrote: > > On Wed, Oct 06, 2021 at 11:43:26AM -0500, Rob Herring wrote: > > Replace open coded parsing of CPU nodes' 'reg' property with > > of_get_cpu_hwid(). > > > > Cc: Jonas Bonn > > Cc: Stefan Kristiansson > > Cc: Stafford Horne > > Cc: openr..

Re: [PATCH 06/12] openrisc: Use of_get_cpu_hwid()

2021-10-06 Thread Stafford Horne
On Wed, Oct 06, 2021 at 11:43:26AM -0500, Rob Herring wrote: > Replace open coded parsing of CPU nodes' 'reg' property with > of_get_cpu_hwid(). > > Cc: Jonas Bonn > Cc: Stefan Kristiansson > Cc: Stafford Horne > Cc: openr...@lists.librecores.org > Signed-off-by: Rob Herring > --- > arch/open

[PATCH 06/12] openrisc: Use of_get_cpu_hwid()

2021-10-06 Thread Rob Herring
Replace open coded parsing of CPU nodes' 'reg' property with of_get_cpu_hwid(). Cc: Jonas Bonn Cc: Stefan Kristiansson Cc: Stafford Horne Cc: openr...@lists.librecores.org Signed-off-by: Rob Herring --- arch/openrisc/kernel/smp.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) dif