Re: [PATCH 05/15] fbdev: imsttfb: remove the dependency on PPC_OF

2015-02-02 Thread Stephen Rothwell
Hi Kevin, On Tue, 3 Feb 2015 10:20:02 +0800 Kevin Hao wrote: > > I took a second look at this. It seems that there is a declaration of > struct device_node in linux/device.h and there is also no access to the > member of device_node in this driver. So we are safe to not include of.h here. > That

Re: [PATCH 05/15] fbdev: imsttfb: remove the dependency on PPC_OF

2015-02-02 Thread Stephen Rothwell
Hi Kevin, On Sun, 1 Feb 2015 13:51:50 +0800 Kevin Hao wrote: > > That was my first thought, but the codes protected by the PPC_OF seem not > ppc specific and should be safe for other archs which also support OF. So I > drop the PPC_OF completely. Did I miss something? Ah, ok. > > > dp = pci_d

Re: [PATCH 05/15] fbdev: imsttfb: remove the dependency on PPC_OF

2015-02-02 Thread Kevin Hao
On Sun, Feb 01, 2015 at 01:51:50PM +0800, Kevin Hao wrote: > > > diff --git a/drivers/video/fbdev/imsttfb.c b/drivers/video/fbdev/imsttfb.c > > > index aae10ce74f14..91a80bb8f988 100644 > > > --- a/drivers/video/fbdev/imsttfb.c > > > +++ b/drivers/video/fbdev/imsttfb.c > > > @@ -1470,7 +1470,6 @@ s

Re: [PATCH 05/15] fbdev: imsttfb: remove the dependency on PPC_OF

2015-01-31 Thread Kevin Hao
On Sun, Feb 01, 2015 at 01:44:33PM +1100, Stephen Rothwell wrote: > Hi Kevin, > > On Sat, 31 Jan 2015 21:47:35 +0800 Kevin Hao wrote: > > > > The OF functionality has moved to a common place and be used by many > > archs. So we don't need to depend on PPC_OF option any more. This is > > a prepara

Re: [PATCH 05/15] fbdev: imsttfb: remove the dependency on PPC_OF

2015-01-31 Thread Stephen Rothwell
Hi Kevin, On Sat, 31 Jan 2015 21:47:35 +0800 Kevin Hao wrote: > > The OF functionality has moved to a common place and be used by many > archs. So we don't need to depend on PPC_OF option any more. This is > a preparation for killing PPC_OF. I suspect that you want to do the PPC_OF -> PPC conver

[PATCH 05/15] fbdev: imsttfb: remove the dependency on PPC_OF

2015-01-31 Thread Kevin Hao
The OF functionality has moved to a common place and be used by many archs. So we don't need to depend on PPC_OF option any more. This is a preparation for killing PPC_OF. Signed-off-by: Kevin Hao --- drivers/video/fbdev/imsttfb.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/vi