Re: [PATCH 04/12] phylib: add a way to make PHY time stamps possible.

2010-06-16 Thread David Miller
From: Richard Cochran Date: Tue, 15 Jun 2010 18:08:20 +0200 > +static inline void skb_tx_timetamp(struct phy_device *phy, struct sk_buff > *skb) > +{ > + union skb_shared_tx *shtx = skb_tx(skb); > + > + if (shtx->hardware && phy && phy->drv->txtstamp) > + phy->drv->txtstamp(p

Re: [PATCH 04/12] phylib: add a way to make PHY time stamps possible.

2010-06-15 Thread Richard Cochran
On Tue, Jun 15, 2010 at 06:08:20PM +0200, Richard Cochran wrote: > +static inline void skb_tx_timetamp(struct phy_device *phy, struct sk_buff > *skb) > +{ > + union skb_shared_tx *shtx = skb_tx(skb); > + > + if (shtx->hardware && phy && phy->drv->txtstamp) > + phy->drv->txtsta

Re: [PATCH 04/12] phylib: add a way to make PHY time stamps possible.

2010-06-15 Thread Richard Cochran
On Tue, Jun 15, 2010 at 10:33:51AM -0600, Grant Likely wrote: > > +config NETWORK_PHY_TIMESTAMPING > Some overhead? At a brief glance of the series it looks like it could > add a lot of overhead, but I'm not fully clear on what the full > process is. Can you describe how the hardware timestamping

Re: [PATCH 04/12] phylib: add a way to make PHY time stamps possible.

2010-06-15 Thread Grant Likely
On Tue, Jun 15, 2010 at 10:08 AM, Richard Cochran wrote: > This patch adds a new networking option to allow hardware time stamps > from PHY devices. Using PHY time stamps will still require adding two > inline function calls to each MAC driver. The CONFIG option makes these > calls safe to add, si

[PATCH 04/12] phylib: add a way to make PHY time stamps possible.

2010-06-15 Thread Richard Cochran
This patch adds a new networking option to allow hardware time stamps from PHY devices. Using PHY time stamps will still require adding two inline function calls to each MAC driver. The CONFIG option makes these calls safe to add, since the calls become NOOPs when the option is disabled. Signed-of