Re: [PATCH 03/15] [PS3] Add region 1 memory early

2011-08-04 Thread Geoff Levand
Hi Hector, On 08/03/2011 05:08 PM, Hector Martin wrote: > On 08/04/2011 12:32 AM, Geoff Levand wrote: >> We need an explanation of this change. Sorry for such a terse request. What I meant was that this is a significant change to how high mem is managed, so the patch needs a comment explaining t

Re: [PATCH 03/15] [PS3] Add region 1 memory early

2011-08-04 Thread Hector Martin
On 08/04/2011 09:05 AM, Geert Uytterhoeven wrote: > The reason for that is to make sure the allocations will succeed. > Chances are very > slim you can allocate a contiguous 9 MiB buffer at any arbitrary time. Fair enough, but then they don't need to happen as early as they do now; any time during

Re: [PATCH 03/15] [PS3] Add region 1 memory early

2011-08-04 Thread Geert Uytterhoeven
On Thu, Aug 4, 2011 at 02:08, Hector Martin wrote: > tight. Can we get rid of the ps3flash and ps3fb preallocations to save > bootmem and just allocate them during device init like the other drivers > do? What is the reason for preallocating these? The reason for that is to make sure the allocati

Re: [PATCH 03/15] [PS3] Add region 1 memory early

2011-08-03 Thread Hector Martin
On 08/04/2011 12:32 AM, Geoff Levand wrote: > We need an explanation of this change. I actually have a hard time understanding the reason for the existing behavior of hot-adding memory halfway through the boot process. Maybe you can shed some light on this? The reason for the change is that under

Re: [PATCH 03/15] [PS3] Add region 1 memory early

2011-08-03 Thread Geoff Levand
On 08/01/2011 01:02 PM, Andre Heider wrote: > From: Hector Martin We need an explanation of this change. > Signed-off-by: Hector Martin > [a.heider: Various cleanups to make checkpatch.pl happy] > Signed-off-by: Andre Heider > --- > arch/powerpc/platforms/ps3/mm.c | 62 > +++---

[PATCH 03/15] [PS3] Add region 1 memory early

2011-08-01 Thread Andre Heider
From: Hector Martin Signed-off-by: Hector Martin [a.heider: Various cleanups to make checkpatch.pl happy] Signed-off-by: Andre Heider --- arch/powerpc/platforms/ps3/mm.c | 62 +++ 1 files changed, 11 insertions(+), 51 deletions(-) diff --git a/arch/powerp