Re: [PATCH 03/12] Consolidate of_device_is_compatible

2007-07-19 Thread David Miller
From: Stephen Rothwell <[EMAIL PROTECTED]> Date: Fri, 20 Jul 2007 01:10:12 +1000 > The only difference here is that Sparc uses strncmp to match compatibility > names while PowerPC uses strncasecmp. > > Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]> Acked-by: David S. Miller <[EMAIL PROTECTE

Re: [PATCH 03/12] Consolidate of_device_is_compatible

2007-07-19 Thread Segher Boessenkool
>> The only difference here is that Sparc uses strncmp to match >> compatibility >> names while PowerPC uses strncasecmp. > > Could we put a comment in saying that both should really just use > strcmp(), and that this mechanism should go away once any > compatibility > issues are found and addr

Re: [PATCH 03/12] Consolidate of_device_is_compatible

2007-07-19 Thread Stephen Rothwell
Hi Scott, On Thu, 19 Jul 2007 10:52:07 -0500 Scott Wood <[EMAIL PROTECTED]> wrote: > > On Fri, Jul 20, 2007 at 01:10:12AM +1000, Stephen Rothwell wrote: > > The only difference here is that Sparc uses strncmp to match compatibility > > names while PowerPC uses strncasecmp. > > Could we put a comm

Re: [PATCH 03/12] Consolidate of_device_is_compatible

2007-07-19 Thread Scott Wood
On Fri, Jul 20, 2007 at 01:10:12AM +1000, Stephen Rothwell wrote: > The only difference here is that Sparc uses strncmp to match compatibility > names while PowerPC uses strncasecmp. Could we put a comment in saying that both should really just use strcmp(), and that this mechanism should go away

[PATCH 03/12] Consolidate of_device_is_compatible

2007-07-19 Thread Stephen Rothwell
The only difference here is that Sparc uses strncmp to match compatibility names while PowerPC uses strncasecmp. Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]> --- arch/powerpc/kernel/prom.c | 25 - arch/sparc/kernel/prom.c | 21 - arch/sparc