Re: [PATCH 01/22] orion5x: Replace comments with C99 initializers

2022-03-28 Thread Daniel Thompson
On Sat, Mar 26, 2022 at 05:58:48PM +0100, Benjamin Stürz wrote: > This replaces comments with C99's designated > initializers because the kernel supports them now. This commit description seems wrong to me. This patch doesn't include use C99 designated initializers (or AFAICT any other language fe

Re: [PATCH 01/22] orion5x: Replace comments with C99 initializers

2022-03-28 Thread Segher Boessenkool
On Sat, Mar 26, 2022 at 08:23:31PM +0100, Arnd Bergmann wrote: > On Sat, Mar 26, 2022 at 5:58 PM Benjamin Stürz wrote: > > > > This replaces comments with C99's designated > > initializers because the kernel supports them now. > > The change looks fine, but the comment looks misplaced, as enum in

Re: [PATCH 01/22] orion5x: Replace comments with C99 initializers

2022-03-26 Thread Arnd Bergmann
On Sat, Mar 26, 2022 at 5:58 PM Benjamin Stürz wrote: > > This replaces comments with C99's designated > initializers because the kernel supports them now. The change looks fine, but the comment looks misplaced, as enum initializers are not c99 feature. Also, the named array and struct intializer

Re: [PATCH 01/22] orion5x: Replace comments with C99 initializers

2022-03-26 Thread Mauro Carvalho Chehab
Em Sat, 26 Mar 2022 17:58:48 +0100 Benjamin Stürz escreveu: > This replaces comments with C99's designated > initializers because the kernel supports them now. Please: 1. Split this series per sub-system. It makes no sense to mailbomb all subsystems for things that won't belong there; 2. Ad