Re: [PATCH 01/16 v2] pmac_zilog: fix unexpected irq

2011-12-06 Thread Finn Thain
On Tue, 6 Dec 2011, Geert Uytterhoeven wrote: > Hi Finn, > > On Tue, Dec 6, 2011 at 16:13, Finn Thain wrote: > > +static void pmz_interrupt_control(struct uart_pmac_port *uap, int enable) > > +{ > > +       if (enable) { > > +               uap->curregs[1] |= INT_ALL_Rx | TxINT_ENAB; > > +    

Re: [PATCH 01/16 v2] pmac_zilog: fix unexpected irq

2011-12-06 Thread Alan Cox
On Wed, 7 Dec 2011 02:13:41 +1100 (EST) Finn Thain wrote: > > On most 68k Macs the SCC IRQ is an autovector interrupt and cannot be > masked. This can be a problem when pmac_zilog starts up. > > For example, the serial debugging code in arch/m68k/kernel/head.S may be > used beforehand. It dis

Re: [PATCH 01/16 v2] pmac_zilog: fix unexpected irq

2011-12-06 Thread Geert Uytterhoeven
Hi Finn, On Tue, Dec 6, 2011 at 16:13, Finn Thain wrote: > +static void pmz_interrupt_control(struct uart_pmac_port *uap, int enable) > +{ > +       if (enable) { > +               uap->curregs[1] |= INT_ALL_Rx | TxINT_ENAB; > +               if (!ZS_IS_EXTCLK(uap)) > +                       uap-

[PATCH 01/16 v2] pmac_zilog: fix unexpected irq

2011-12-06 Thread Finn Thain
On most 68k Macs the SCC IRQ is an autovector interrupt and cannot be masked. This can be a problem when pmac_zilog starts up. For example, the serial debugging code in arch/m68k/kernel/head.S may be used beforehand. It disables the SCC interrupts at the chip but doesn't ack them. Then when a