Re: [PATCH 01/15] video: fbdev: atmel_lcdfb: Rework backlight handling

2023-01-09 Thread Stephen Kitt
Hi Sam, On Sun, 8 Jan 2023 21:24:20 +0100, Sam Ravnborg wrote: > > Here are my pending patches from last June on lore: > > > > All patches are handled I think except this: > > * https://lore.kernel.org/lkml/20220608205623.2106113-1-st...@sk2.org/ > > Can I ask you to drop the assignment th

Re: [PATCH 01/15] video: fbdev: atmel_lcdfb: Rework backlight handling

2023-01-09 Thread Helge Deller
On 1/9/23 21:18, Stephen Kitt wrote: On Sun, 8 Jan 2023 18:26:12 +0100, Helge Deller wrote: On 1/7/23 21:53, Sam Ravnborg wrote: Hi Stephen. On Sat, Jan 07, 2023 at 09:36:47PM +0100, Stephen Kitt wrote: On 7 January 2023 19:26:15 CET, Sam Ravnborg via B4 Submission Endpoint wrote: From: S

Re: [PATCH 01/15] video: fbdev: atmel_lcdfb: Rework backlight handling

2023-01-09 Thread Stephen Kitt
On Sun, 8 Jan 2023 18:26:12 +0100, Helge Deller wrote: > On 1/7/23 21:53, Sam Ravnborg wrote: > > Hi Stephen. > > > > On Sat, Jan 07, 2023 at 09:36:47PM +0100, Stephen Kitt wrote: > >> On 7 January 2023 19:26:15 CET, Sam Ravnborg via B4 Submission Endpoint > >> wrote: > >>> From: Sam Ravnbor

Re: [PATCH 01/15] video: fbdev: atmel_lcdfb: Rework backlight handling

2023-01-09 Thread Stephen Kitt
On Mon, 9 Jan 2023 20:53:44 +0100, Stephen Kitt wrote: > On Sun, 8 Jan 2023 21:24:20 +0100, Sam Ravnborg wrote: > > > Here are my pending patches from last June on lore: > > > > > > > All patches are handled I think except this: > > > * https://lore.kernel.org/lkml/20220608205623.2106113-

Re: [PATCH 01/15] video: fbdev: atmel_lcdfb: Rework backlight handling

2023-01-09 Thread Jani Nikula
On Sat, 07 Jan 2023, Sam Ravnborg via B4 Submission Endpoint wrote: > From: Sam Ravnborg > > The atmel_lcdfb had code to save/restore power state. > This is not needed so drop it. > > Introduce backlight_is_brightness() to make logic simpler. backlight_is_brightness? BR, Jani. > > Signed-off

Re: [PATCH 01/15] video: fbdev: atmel_lcdfb: Rework backlight handling

2023-01-08 Thread Sam Ravnborg
Hi Helge, > > > > Helge - could you pick the reviewed patches from: > > https://lore.kernel.org/all/20220607192335.1137249-1-st...@sk2.org/ > > [This is the same mail as Stephen refer to above - looked up via lore]. > > I just pulled those 7 patches into fbdev/for-next. > If you need more, pleas

Re: [PATCH 01/15] video: fbdev: atmel_lcdfb: Rework backlight handling

2023-01-08 Thread Sam Ravnborg
Hi Stephen. > Here are my pending patches from last June on lore: > All patches are handled I think except this: > * https://lore.kernel.org/lkml/20220608205623.2106113-1-st...@sk2.org/ Can I ask you to drop the assignment that is not needed, and resend with the collected acks/r-b. With this

Re: [PATCH 01/15] video: fbdev: atmel_lcdfb: Rework backlight handling

2023-01-08 Thread Helge Deller
On 1/7/23 21:53, Sam Ravnborg wrote: Hi Stephen. On Sat, Jan 07, 2023 at 09:36:47PM +0100, Stephen Kitt wrote: On 7 January 2023 19:26:15 CET, Sam Ravnborg via B4 Submission Endpoint wrote: From: Sam Ravnborg The atmel_lcdfb had code to save/restore power state. This is not needed so drop

Re: [PATCH 01/15] video: fbdev: atmel_lcdfb: Rework backlight handling

2023-01-08 Thread Stephen Kitt
On 7 January 2023 21:53:46 CET, Sam Ravnborg wrote: >Hi Stephen. > >On Sat, Jan 07, 2023 at 09:36:47PM +0100, Stephen Kitt wrote: >> On 7 January 2023 19:26:15 CET, Sam Ravnborg via B4 Submission Endpoint >> wrote: >> >From: Sam Ravnborg >> > >> >The atmel_lcdfb had code to save/restore power s

Re: [PATCH 01/15] video: fbdev: atmel_lcdfb: Rework backlight handling

2023-01-07 Thread Stephen Kitt
On 8 January 2023 08:45:46 CET, Stephen Kitt wrote: >On 7 January 2023 21:53:46 CET, Sam Ravnborg wrote: >>Hi Stephen. >> >>On Sat, Jan 07, 2023 at 09:36:47PM +0100, Stephen Kitt wrote: >>> On 7 January 2023 19:26:15 CET, Sam Ravnborg via B4 Submission Endpoint >>> wrote: >>> >From: Sam Ravnbor

[PATCH 01/15] video: fbdev: atmel_lcdfb: Rework backlight handling

2023-01-07 Thread Sam Ravnborg via B4 Submission Endpoint
From: Sam Ravnborg The atmel_lcdfb had code to save/restore power state. This is not needed so drop it. Introduce backlight_is_brightness() to make logic simpler. Signed-off-by: Sam Ravnborg Cc: Nicolas Ferre Cc: Alexandre Belloni Cc: Ludovic Desroches Cc: linux-fb...@vger.kernel.org Cc: li

Re: [PATCH 01/15] video: fbdev: atmel_lcdfb: Rework backlight handling

2023-01-07 Thread Sam Ravnborg
Hi Stephen. On Sat, Jan 07, 2023 at 09:36:47PM +0100, Stephen Kitt wrote: > On 7 January 2023 19:26:15 CET, Sam Ravnborg via B4 Submission Endpoint > wrote: > >From: Sam Ravnborg > > > >The atmel_lcdfb had code to save/restore power state. > >This is not needed so drop it. > > > >Introduce back

Re: [PATCH 01/15] video: fbdev: atmel_lcdfb: Rework backlight handling

2023-01-07 Thread Stephen Kitt
On 7 January 2023 19:26:15 CET, Sam Ravnborg via B4 Submission Endpoint wrote: >From: Sam Ravnborg > >The atmel_lcdfb had code to save/restore power state. >This is not needed so drop it. > >Introduce backlight_is_brightness() to make logic simpler. > >Signed-off-by: Sam Ravnborg >Cc: Nicolas F