Re: [PATCH 01/11] powerpc: remove dead ifdefs in

2019-02-15 Thread Masahiro Yamada
On Fri, Feb 15, 2019 at 5:18 PM Christophe Leroy wrote: > > > > Le 14/02/2019 à 18:05, Christoph Hellwig a écrit : > > On Thu, Feb 14, 2019 at 09:26:19AM +0100, Christophe Leroy wrote: > >> Could you also remove the 'config GENERIC_CSUM' item in > >> arch/powerpc/Kconfig ? > > > > All the separate

Re: [PATCH 01/11] powerpc: remove dead ifdefs in

2019-02-15 Thread Christophe Leroy
Le 14/02/2019 à 18:05, Christoph Hellwig a écrit : On Thu, Feb 14, 2019 at 09:26:19AM +0100, Christophe Leroy wrote: Could you also remove the 'config GENERIC_CSUM' item in arch/powerpc/Kconfig ? All the separate declarations go away later in this series. I saw, but the purpose of the la

Re: [PATCH 01/11] powerpc: remove dead ifdefs in

2019-02-14 Thread Christoph Hellwig
On Thu, Feb 14, 2019 at 09:26:19AM +0100, Christophe Leroy wrote: > Could you also remove the 'config GENERIC_CSUM' item in > arch/powerpc/Kconfig ? All the separate declarations go away later in this series.

Re: [PATCH 01/11] powerpc: remove dead ifdefs in

2019-02-14 Thread Andreas Schwab
On Feb 13 2019, Christoph Hellwig wrote: > __KERNEL__ is never not defined for non-uapi headers, and GENERIC_CSUM "... never not ... non-..." That's a bit too negative, I think. :-) Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4

Re: [PATCH 01/11] powerpc: remove dead ifdefs in

2019-02-14 Thread Christophe Leroy
Le 13/02/2019 à 18:39, Christoph Hellwig a écrit : __KERNEL__ is never not defined for non-uapi headers, and GENERIC_CSUM isn't ever set for powerpc either. GENERIC_CSUM was abandonned by commit d4fde568a34a ("powerpc/64: Use optimized checksum routines on little-endian") Could you also r

[PATCH 01/11] powerpc: remove dead ifdefs in

2019-02-13 Thread Christoph Hellwig
__KERNEL__ is never not defined for non-uapi headers, and GENERIC_CSUM isn't ever set for powerpc either. Signed-off-by: Christoph Hellwig --- arch/powerpc/include/asm/checksum.h | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/arch/powerpc/include/asm/checksum.h b/arc