Re: [PATCH 01/11] fs_enet: Add support for MPC512x to fs_enet driver

2010-01-20 Thread Scott Wood
Anatolij Gustschin wrote: Scott Wood wrote: You can put a data pointer in the of_platform match struct, instead of re-checking the compatible. .data pointer in 'fs_enet_mdio_fec_match' is already used for mpc5xxx_get_bus_frequency(). Setting .data to some sort of FEC ID in match struct for "f

Re: [PATCH 01/11] fs_enet: Add support for MPC512x to fs_enet driver

2010-01-20 Thread Anatolij Gustschin
Scott Wood wrote: > > + void __iomem *fec_fun_code; > > + void __iomem *fec_r_hash; > > + void __iomem *fec_x_cntrl; > > + void __iomem *fec_dma_control; > > +}; > > Why void and not the specific type? Ok, I will fix it for using u32 __iomem *. > > static void set_promiscuous_mode(str

Re: [PATCH 01/11] fs_enet: Add support for MPC512x to fs_enet driver

2010-01-19 Thread Scott Wood
Anatolij Gustschin wrote: +struct reg_tbl { + void __iomem *fec_ievent; + void __iomem *fec_imask; + void __iomem *fec_r_des_active; + void __iomem *fec_x_des_active; + void __iomem *fec_r_des_start; + void __iomem *fec_x_des_start; + void __iomem *fec_r_

[PATCH 01/11] fs_enet: Add support for MPC512x to fs_enet driver

2010-01-19 Thread Anatolij Gustschin
drivers/net/fs_enet/* Enable fs_enet driver to work 5121 FEC Enable it with CONFIG_FS_ENET_MPC5121_FEC Signed-off-by: John Rigby Signed-off-by: Piotr Ziecik Signed-off-by: Wolfgang Denk Signed-off-by: Anatolij Gustschin Cc: Cc: Grant Likely Cc: John Rigby --- drivers/ne