Re: [PATCH 01/10] irq: move some interrupt arch_* functions into struct irq_chip.

2010-03-24 Thread Thomas Gleixner
On Wed, 24 Mar 2010, Ian Campbell wrote: > On Wed, 2010-03-24 at 17:44 +, Thomas Gleixner wrote: > > On Wed, 24 Mar 2010, Ian Campbell wrote: > > > > > On Mon, 2010-03-22 at 10:19 +, Thomas Gleixner wrote: > > > > On Sun, 21 Mar 2010, Yinghai Lu wrote: > > > > > > > > > From: Ian Campbel

Re: [PATCH 01/10] irq: move some interrupt arch_* functions into struct irq_chip.

2010-03-24 Thread Ian Campbell
On Wed, 2010-03-24 at 17:44 +, Thomas Gleixner wrote: > On Wed, 24 Mar 2010, Ian Campbell wrote: > > > On Mon, 2010-03-22 at 10:19 +, Thomas Gleixner wrote: > > > On Sun, 21 Mar 2010, Yinghai Lu wrote: > > > > > > > From: Ian Campbell > > > > > > > > Move arch_init_copy_chip_data and a

Re: [PATCH 01/10] irq: move some interrupt arch_* functions into struct irq_chip.

2010-03-24 Thread Thomas Gleixner
On Wed, 24 Mar 2010, Ian Campbell wrote: > On Mon, 2010-03-22 at 10:19 +, Thomas Gleixner wrote: > > On Sun, 21 Mar 2010, Yinghai Lu wrote: > > > > > From: Ian Campbell > > > > > > Move arch_init_copy_chip_data and arch_free_chip_data into function > > > pointers in struct irq_chip since th

Re: [PATCH 01/10] irq: move some interrupt arch_* functions into struct irq_chip.

2010-03-24 Thread Ian Campbell
On Tue, 2010-03-23 at 07:10 +, Paul Mundt wrote: > The function pointer thing itself is also a bit unorthodox to say the > least. You're introducing and passing around an opaque type just so you > can get to a 'return 0' in the xen case as far as I can tell, The ultimate aim is to have Xen us

Re: [PATCH 01/10] irq: move some interrupt arch_* functions into struct irq_chip.

2010-03-24 Thread Ian Campbell
On Mon, 2010-03-22 at 10:19 +, Thomas Gleixner wrote: > On Sun, 21 Mar 2010, Yinghai Lu wrote: > > > From: Ian Campbell > > > > Move arch_init_copy_chip_data and arch_free_chip_data into function > > pointers in struct irq_chip since they operate on irq_desc->chip_data. > > Not sure about t

Re: [PATCH 01/10] irq: move some interrupt arch_* functions into struct irq_chip.

2010-03-23 Thread Paul Mundt
On Sun, Mar 21, 2010 at 08:32:33PM -0700, Yinghai Lu wrote: > diff --git a/arch/powerpc/kernel/irq.c b/arch/powerpc/kernel/irq.c > index 64f6f20..cafd378 100644 > --- a/arch/powerpc/kernel/irq.c > +++ b/arch/powerpc/kernel/irq.c > @@ -1088,7 +1088,7 @@ int arch_early_irq_init(void) > return 0

Re: [PATCH 01/10] irq: move some interrupt arch_* functions into struct irq_chip.

2010-03-22 Thread Thomas Gleixner
On Sun, 21 Mar 2010, Yinghai Lu wrote: > From: Ian Campbell > > Move arch_init_copy_chip_data and arch_free_chip_data into function > pointers in struct irq_chip since they operate on irq_desc->chip_data. Not sure about that. These functions are solely used by x86 and there is really no need to

Re: [PATCH 01/10] irq: move some interrupt arch_* functions into struct irq_chip.

2010-03-21 Thread Yinghai Lu
On 03/21/2010 06:56 PM, Michael Ellerman wrote: > On Sun, 2010-03-21 at 18:36 -0700, Yinghai Lu wrote: >> From: Ian Campbell > ... >> To replace the x86 arch_init_chip_data functionality >> irq_to_desc_alloc_node now takes a pointer to a function to allocate >> the chip data. This is necessary to

Re: [PATCH 01/10] irq: move some interrupt arch_* functions into struct irq_chip.

2010-03-21 Thread Michael Ellerman
On Sun, 2010-03-21 at 18:36 -0700, Yinghai Lu wrote: > From: Ian Campbell ... > To replace the x86 arch_init_chip_data functionality > irq_to_desc_alloc_node now takes a pointer to a function to allocate > the chip data. This is necessary to ensure the allocation happens > under the correct lockin

[PATCH 01/10] irq: move some interrupt arch_* functions into struct irq_chip.

2010-03-21 Thread Yinghai Lu
From: Ian Campbell Move arch_init_copy_chip_data and arch_free_chip_data into function pointers in struct irq_chip since they operate on irq_desc->chip_data. arch_init_chip_data cannot be moved into struct irq_chip because irq_desc->chip is not known at the time the irq_desc is setup. Instead re