Re: [PATCH 00/22] Replace comments with C99 initializers

2022-03-28 Thread Jakub Kicinski
On Mon, 28 Mar 2022 13:51:42 +0200 Benjamin Stürz wrote: > > Just a small tip: If you are new, start with something small and learn > > from that. Don't do a controversial big patchset spanning multiple > > subsystems, that's the hard way to learn things. First submit one patch > > at a time to one

Re: [PATCH 00/22] Replace comments with C99 initializers

2022-03-28 Thread Daniel Thompson
On Sun, Mar 27, 2022 at 02:46:00PM +0200, Benjamin Stürz wrote: > This patch series replaces comments with C99's designated initializers > in a few places. It also adds some enum initializers. This is my first > time contributing to the Linux kernel, therefore I'm probably doing a > lot of things t

Re: [PATCH 00/22] Replace comments with C99 initializers

2022-03-28 Thread Kalle Valo
Benjamin Stürz writes: > On 28.03.22 11:33, Kalle Valo wrote: >> Benjamin Stürz writes: >> >>> This patch series replaces comments with C99's designated initializers >>> in a few places. It also adds some enum initializers. This is my first >>> time contributing to the Linux kernel, therefore I

Re: [PATCH 00/22] Replace comments with C99 initializers

2022-03-28 Thread Kalle Valo
Benjamin Stürz writes: > This patch series replaces comments with C99's designated initializers > in a few places. It also adds some enum initializers. This is my first > time contributing to the Linux kernel, therefore I'm probably doing a > lot of things the wrong way. I'm sorry for that. Just