Re: [PATCH 0/3] OF-platform PATA driver

2007-12-02 Thread Olof Johansson
On Mon, Dec 03, 2007 at 12:40:21AM +0100, Arnd Bergmann wrote: > On Sunday 02 December 2007, Olof Johansson wrote: > > > Yes, I agree with Sergei: I don't think the pio/ata mode belongs there, > > "ata-generic" (or "generic-ata") sounds good to me. If firmwares want to > > specify pata/sata stuff

Re: [PATCH 0/3] OF-platform PATA driver

2007-12-02 Thread Arnd Bergmann
On Sunday 02 December 2007, Olof Johansson wrote: > Yes, I agree with Sergei: I don't think the pio/ata mode belongs there, > "ata-generic" (or "generic-ata") sounds good to me. If firmwares want to > specify pata/sata stuff as more specific compatible fields, then they are > free to, but the driv

Re: [PATCH 0/3] OF-platform PATA driver

2007-12-02 Thread Olof Johansson
On Sun, Dec 02, 2007 at 02:46:17PM +0300, Anton Vorontsov wrote: > On Sat, Dec 01, 2007 at 09:57:55PM -0600, Olof Johansson wrote: > > On Sun, Dec 02, 2007 at 02:58:10AM +0300, Anton Vorontsov wrote: > > > On Sat, Dec 01, 2007 at 05:54:49PM -0500, Jeff Garzik wrote: > > > while (1) { > > > send_p

Re: [PATCH 0/3] OF-platform PATA driver

2007-12-02 Thread Anton Vorontsov
On Sat, Dec 01, 2007 at 09:57:55PM -0600, Olof Johansson wrote: > On Sun, Dec 02, 2007 at 02:58:10AM +0300, Anton Vorontsov wrote: > > On Sat, Dec 01, 2007 at 05:54:49PM -0500, Jeff Garzik wrote: > > while (1) { > > send_patches(); > > > > if (ack_collected(PaulM) && ack_collected(PowerPC_

Re: [PATCH 0/3] OF-platform PATA driver

2007-12-01 Thread Olof Johansson
On Sun, Dec 02, 2007 at 02:58:10AM +0300, Anton Vorontsov wrote: > On Sat, Dec 01, 2007 at 05:54:49PM -0500, Jeff Garzik wrote: > while (1) { > send_patches(); > > if (ack_collected(PaulM) && ack_collected(PowerPC_people)) > break; > > sleep(wait_for_comments_timeo

Re: [PATCH 0/3] OF-platform PATA driver

2007-12-01 Thread Anton Vorontsov
On Sat, Dec 01, 2007 at 05:54:49PM -0500, Jeff Garzik wrote: > Anton Vorontsov wrote: > > Hi all, > > > > Here is the second spin of the OF-platform PATA driver and > > related patches. > > > > Changes since RFC: > > - nuked drivers/ata/pata_platform.h; > > - powerpc bits: proper localbus node ad

Re: [PATCH 0/3] OF-platform PATA driver

2007-12-01 Thread Jeff Garzik
Anton Vorontsov wrote: > Hi all, > > Here is the second spin of the OF-platform PATA driver and > related patches. > > Changes since RFC: > - nuked drivers/ata/pata_platform.h; > - powerpc bits: proper localbus node added. > > > Thanks for the previous review! This time I'm collecting acks, > d

Re: [PATCH 0/3] OF-platform PATA driver

2007-11-28 Thread Anton Vorontsov
On Wed, Nov 28, 2007 at 06:51:51PM +0900, Paul Mundt wrote: > On Tue, Nov 27, 2007 at 06:37:08PM +0300, Anton Vorontsov wrote: > > Here is the second spin of the OF-platform PATA driver and > > related patches. > > > So either the patches are missing, or I wasn't CC'ed on them. I'm going > to go o

Re: [PATCH 0/3] OF-platform PATA driver

2007-11-28 Thread Paul Mundt
On Tue, Nov 27, 2007 at 06:37:08PM +0300, Anton Vorontsov wrote: > Here is the second spin of the OF-platform PATA driver and > related patches. > So either the patches are missing, or I wasn't CC'ed on them. I'm going to go out on a limb and assume the latter. If you wish me to Ack them, I'm not

[PATCH 0/3] OF-platform PATA driver

2007-11-27 Thread Anton Vorontsov
Hi all, Here is the second spin of the OF-platform PATA driver and related patches. Changes since RFC: - nuked drivers/ata/pata_platform.h; - powerpc bits: proper localbus node added. Thanks for the previous review! This time I'm collecting acks, don't be shy to give 'em generously. ;-) Good

Re: [RFC][PATCH 0/3] OF-platform PATA driver

2007-11-25 Thread Paul Mundt
On Mon, Nov 26, 2007 at 03:23:14AM +0300, Anton Vorontsov wrote: > On Sat, Nov 24, 2007 at 04:26:13PM +0900, Paul Mundt wrote: > > On Fri, Nov 23, 2007 at 07:49:33PM -0500, Jeff Garzik wrote: > > > Anton Vorontsov wrote: > > > >Here is the PATA Platform driver using OF infrastructure. > > > > > > >

Re: [RFC][PATCH 0/3] OF-platform PATA driver

2007-11-25 Thread Anton Vorontsov
On Sat, Nov 24, 2007 at 04:26:13PM +0900, Paul Mundt wrote: > On Fri, Nov 23, 2007 at 07:49:33PM -0500, Jeff Garzik wrote: > > Anton Vorontsov wrote: > > >Here is the PATA Platform driver using OF infrastructure. > > > > > >Mostly it's just a wrapper around a bit modified pata_platform > > >driver.

Re: [RFC][PATCH 0/3] OF-platform PATA driver

2007-11-25 Thread Anton Vorontsov
On Sat, Nov 24, 2007 at 09:50:07PM +0100, Arnd Bergmann wrote: > On Friday 23 November 2007, Anton Vorontsov wrote: > > Here is the PATA Platform driver using OF infrastructure. > > > > Mostly it's just a wrapper around a bit modified pata_platform > > driver. > > Thanks a lot for doing this. Pat

Re: [RFC][PATCH 0/3] OF-platform PATA driver

2007-11-24 Thread Arnd Bergmann
On Friday 23 November 2007, Anton Vorontsov wrote: > Here is the PATA Platform driver using OF infrastructure. > > Mostly it's just a wrapper around a bit modified pata_platform > driver. Thanks a lot for doing this. Patches 2/3 are what I tried to get people to do for some time now but was too l

Re: [RFC][PATCH 0/3] OF-platform PATA driver

2007-11-23 Thread Paul Mundt
On Fri, Nov 23, 2007 at 07:49:33PM -0500, Jeff Garzik wrote: > Anton Vorontsov wrote: > >Here is the PATA Platform driver using OF infrastructure. > > > >Mostly it's just a wrapper around a bit modified pata_platform > >driver. > > > >Patches are well split for the easier review: > > > >First one f

Re: [RFC][PATCH 0/3] OF-platform PATA driver

2007-11-23 Thread Vitaly Bordug
On Fri, 23 Nov 2007 20:52:29 +0300 Anton Vorontsov wrote: > Hi all, > > Here is the PATA Platform driver using OF infrastructure. > > Mostly it's just a wrapper around a bit modified pata_platform > driver. > > Patches are well split for the easier review: > > First one factors out platform_de

Re: [RFC][PATCH 0/3] OF-platform PATA driver

2007-11-23 Thread Benjamin Herrenschmidt
On Fri, 2007-11-23 at 20:52 +0300, Anton Vorontsov wrote: > As an alternative approach we can use plain pata_platform > driver, but I'm not sure how Linux OF bindings' ideologists will > or will not like it. > > So, these patches are strongly Request For Comments. Feel free > to train your nitpi

Re: [RFC][PATCH 0/3] OF-platform PATA driver

2007-11-23 Thread Jeff Garzik
Anton Vorontsov wrote: > Hi all, > > Here is the PATA Platform driver using OF infrastructure. > > Mostly it's just a wrapper around a bit modified pata_platform > driver. > > Patches are well split for the easier review: > > First one factors out platform_device specific bits and modifies > pa

[RFC][PATCH 0/3] OF-platform PATA driver

2007-11-23 Thread Anton Vorontsov
Hi all, Here is the PATA Platform driver using OF infrastructure. Mostly it's just a wrapper around a bit modified pata_platform driver. Patches are well split for the easier review: First one factors out platform_device specific bits and modifies pata_platform to be a library-alike driver (wit