Re: [PATCH -v2] Audit: push audit success and retcode into arch ptrace.h

2011-06-08 Thread Oleg Nesterov
On 06/08, Oleg Nesterov wrote: > > OK. Thanks a lot Eric for your explanations. Yes. but may I ask another one? Shouldn't copy_process()->audit_alloc(tsk) path do clear_tsk_thread_flag(tsk, TIF_SYSCALL_AUDIT) if it doesn't set tsk->audit_context? I can be easily wrong, but afaics otherwise the c

Re: [PATCH -v2] Audit: push audit success and retcode into arch ptrace.h

2011-06-08 Thread Oleg Nesterov
On 06/08, Eric Paris wrote: > > On Wed, 2011-06-08 at 18:36 +0200, Oleg Nesterov wrote: > > And I guess, all CONFIG_AUDITSYSCALL code in entry.S is only needed to > > microoptimize the case when TIF_SYSCALL_AUDIT is the only reason for the > > slow path. I wonder if it really makes the measureble d

Re: [PATCH -v2] Audit: push audit success and retcode into arch ptrace.h

2011-06-08 Thread Eric Paris
On Wed, 2011-06-08 at 18:36 +0200, Oleg Nesterov wrote: > On 06/07, Eric Paris wrote: > > > > On Tue, 2011-06-07 at 19:19 +0200, Oleg Nesterov wrote: > > > > > > With or without this patch, can't we call audit_syscall_exit() twice > > > if there is something else in _TIF_WORK_SYSCALL_EXIT mask apar

Re: [PATCH -v2] Audit: push audit success and retcode into arch ptrace.h

2011-06-08 Thread Oleg Nesterov
On 06/07, Eric Paris wrote: > > On Tue, 2011-06-07 at 19:19 +0200, Oleg Nesterov wrote: > > > > With or without this patch, can't we call audit_syscall_exit() twice > > if there is something else in _TIF_WORK_SYSCALL_EXIT mask apart from > > SYSCALL_AUDIT ? First time it is called from asm, then fr

Re: [PATCH -v2] Audit: push audit success and retcode into arch ptrace.h

2011-06-08 Thread Ralf Baechle
On Fri, Jun 03, 2011 at 06:04:51PM -0400, Eric Paris wrote: Thanks, this looks good & compiles, so: Acked-by: Ralf Baechle I will rebase my pending MIPS audit patches on top of this patch and resend. Thanks, Ralf ___ Linuxppc-dev mailing list Linu

Re: [PATCH -v2] Audit: push audit success and retcode into arch ptrace.h

2011-06-07 Thread Eric Paris
On Tue, 2011-06-07 at 19:19 +0200, Oleg Nesterov wrote: > On 06/03, Eric Paris wrote: > > > > The audit system previously expected arches calling to audit_syscall_exit to > > supply as arguments if the syscall was a success and what the return code > > was. > > Audit also provides a helper AUDITSC

Re: [PATCH -v2] Audit: push audit success and retcode into arch ptrace.h

2011-06-07 Thread Oleg Nesterov
On 06/03, Eric Paris wrote: > > The audit system previously expected arches calling to audit_syscall_exit to > supply as arguments if the syscall was a success and what the return code was. > Audit also provides a helper AUDITSC_RESULT which was supposed to simplify > things > by converting from n

Re: [PATCH -v2] Audit: push audit success and retcode into arch ptrace.h

2011-06-06 Thread David Miller
From: Eric Paris Date: Fri, 03 Jun 2011 18:04:51 -0400 ... > Signed-off-by: Eric Paris > Acked-by: Acked-by: H. Peter Anvin [for x86 portion] For sparc parts: Acked-by: David S. Miller ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org ht

Re: [PATCH -v2] Audit: push audit success and retcode into arch ptrace.h

2011-06-04 Thread Richard Weinberger
Am Samstag 04 Juni 2011, 00:04:51 schrieb Eric Paris: > The audit system previously expected arches calling to audit_syscall_exit > to supply as arguments if the syscall was a success and what the return > code was. Audit also provides a helper AUDITSC_RESULT which was supposed > to simplify things

Re: [PATCH -v2] Audit: push audit success and retcode into arch ptrace.h

2011-06-03 Thread Tony Luck
On Fri, Jun 3, 2011 at 3:04 PM, Eric Paris wrote: > The other major change is that on some arches, like ia64, we change > regs_return_value() to give us the negative value on syscall failure.  The > only other user of this macro, kretprobe_example.c, won't notice and it makes > the value signed co

[PATCH -v2] Audit: push audit success and retcode into arch ptrace.h

2011-06-03 Thread Eric Paris
The audit system previously expected arches calling to audit_syscall_exit to supply as arguments if the syscall was a success and what the return code was. Audit also provides a helper AUDITSC_RESULT which was supposed to simplify things by converting from negative retcodes to an audit internal ma