Re: [PATCH]460EX on-chip SATA driver

2010-06-29 Thread Anton Vorontsov
On Tue, Jun 29, 2010 at 03:33:50AM +0200, Marek Vasut wrote: > Dne Pá 4. června 2010 14:26:17 Rupjyoti Sarmah napsal(a): > > This patch enables the on-chip DWC SATA controller of the AppliedMicro > > processor 460EX. > > > > Signed-off-by: Rupjyoti Sarmah > > Signed-off-by: Mark Miesfeld > > Sig

RE: [PATCH]460EX on-chip SATA driver

2010-06-29 Thread Rupjyoti Sarmah
-...@vger.kernel.org; linux-ker...@vger.kernel.org; jgar...@pobox.com; s...@denx.de; linuxppc-...@ozlabs.org Subject: Re: [PATCH]460EX on-chip SATA driver Dne Pá 4. června 2010 14:26:17 Rupjyoti Sarmah napsal(a): > This patch enables the on-chip DWC SATA controller of the AppliedMicro > processor

Re: [PATCH]460EX on-chip SATA driver

2010-06-28 Thread Marek Vasut
Dne Pá 4. června 2010 14:26:17 Rupjyoti Sarmah napsal(a): > This patch enables the on-chip DWC SATA controller of the AppliedMicro > processor 460EX. > > Signed-off-by: Rupjyoti Sarmah > Signed-off-by: Mark Miesfeld > Signed-off-by: Prodyut Hazarika > --SNIP-- > + dev_err(ap->dev

Re: [PATCH]460EX on-chip SATA driver

2010-06-17 Thread Jassi Brar
On Fri, Jun 4, 2010 at 9:26 PM, Rupjyoti Sarmah wrote: > This patch enables the on-chip DWC SATA controller of the AppliedMicro > processor 460EX. Doesn't this DWC sata IP provide AHCI ? Just curious. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.oz

Re: [PATCH]460EX on-chip SATA driver

2010-06-06 Thread Wolfgang Denk
Dear Rupjyoti Sarmah, In message <201006041226.o54cqh2v017...@amcc.com> you wrote: > This patch enables the on-chip DWC SATA controller of the AppliedMicro > processor 460EX. > > Signed-off-by: Rupjyoti Sarmah > Signed-off-by: Mark Miesfeld > Signed-off-by: Prodyut Hazarika > > --- > drive

Re: [PATCH]460EX on-chip SATA driver

2010-06-06 Thread Josh Boyer
On Fri, Jun 04, 2010 at 05:56:17PM +0530, Rupjyoti Sarmah wrote: >This patch enables the on-chip DWC SATA controller of the AppliedMicro >processor 460EX. > >Signed-off-by: Rupjyoti Sarmah >Signed-off-by: Mark Miesfeld >Signed-off-by: Prodyut Hazarika What does the mean in the Subject? > >-

[PATCH]460EX on-chip SATA driver

2010-06-04 Thread Rupjyoti Sarmah
This patch enables the on-chip DWC SATA controller of the AppliedMicro processor 460EX. Signed-off-by: Rupjyoti Sarmah Signed-off-by: Mark Miesfeld Signed-off-by: Prodyut Hazarika --- drivers/ata/Kconfig |9 + drivers/ata/Makefile |1 + drivers/ata/sata_dwc_460ex.c

Re: [PATCH]460EX on-chip SATA driver < resubmission >

2010-05-19 Thread Jassi Brar
On Wed, May 19, 2010 at 6:53 PM, Alan Cox wrote: > On Wed, 19 May 2010 10:49:59 +0900 > Jassi Brar wrote: > >> On Thu, May 6, 2010 at 2:57 AM, Rupjyoti Sarmah wrote: >> > This patch enables the on-chip DWC SATA controller of the AppliedMicro >> > processor 460EX. >> >> The controller seems to b

Re: [PATCH]460EX on-chip SATA driver < resubmission >

2010-05-19 Thread Alan Cox
On Wed, 19 May 2010 10:49:59 +0900 Jassi Brar wrote: > On Thu, May 6, 2010 at 2:57 AM, Rupjyoti Sarmah wrote: > > This patch enables the on-chip DWC SATA controller of the AppliedMicro > > processor 460EX. > > The controller seems to be a thrid party IP (from Synopsys) in your > SoC and there

Re: [PATCH]460EX on-chip SATA driver < resubmission >

2010-05-18 Thread Jassi Brar
On Thu, May 6, 2010 at 2:57 AM, Rupjyoti Sarmah wrote: > This patch enables the on-chip DWC SATA controller of the AppliedMicro > processor 460EX. The controller seems to be a thrid party IP (from Synopsys) in your SoC and there are many chances the IP will appear in some other SOCs too. This im

Re: [PATCH]460EX on-chip SATA driver < resubmission >

2010-05-17 Thread Benjamin Herrenschmidt
> > Additionally, the boot wrapper should probably either remove the node or > > at least use a status property "ok" / "disabled" to represent whether > > the board is configured for SATA or PCIe x1... > > U-Boot already sets the "status" property of the PCIe or SATA node > accordingly. Just let

Re: [PATCH]460EX on-chip SATA driver < resubmission >

2010-05-17 Thread Stefan Roese
Hi Ben, On Sunday 16 May 2010 01:40:28 Benjamin Herrenschmidt wrote: > > > + SATA0: s...@bffd1000 { > > > +compatible = "amcc,sata-460ex"; > > > + reg = <4 0xbffd1000 0x800 4 0xbffd0800 0x400>; > > > +interrupt-parent = <&UIC3

Re: [PATCH]460EX on-chip SATA driver < resubmission >

2010-05-15 Thread Benjamin Herrenschmidt
On Fri, 2010-05-14 at 21:44 +0400, Sergei Shtylyov wrote: > Hello. > > Rupjyoti Sarmah wrote: > > > This patch enables the on-chip DWC SATA controller of the AppliedMicro > > processor 460EX. > > > > Signed-off-by: Rupjyoti Sarmah > > Signed-off-by: Mark Miesfeld > > Signed-off-by: Prodyut Ha

Re: [PATCH]460EX on-chip SATA driver < resubmission >

2010-05-14 Thread Jeff Garzik
On 05/05/2010 01:57 PM, Rupjyoti Sarmah wrote: +static void clear_interrupt_bit(struct sata_dwc_device *hsdev, u32 bit) +{ + out_le32(&hsdev->sata_dwc_regs->intpr, +in_le32(&hsdev->sata_dwc_regs->intpr)); +} + +static u32 qcmd_tag_to_mask(u8 tag) +{ + return 0x00

Re: [PATCH]460EX on-chip SATA driver < resubmission >

2010-05-14 Thread Sergei Shtylyov
Hello. Rupjyoti Sarmah wrote: This patch enables the on-chip DWC SATA controller of the AppliedMicro processor 460EX. Signed-off-by: Rupjyoti Sarmah Signed-off-by: Mark Miesfeld Signed-off-by: Prodyut Hazarika --- arch/powerpc/boot/dts/canyonlands.dts |8 + drivers/ata/Kconfig

[PATCH]460EX on-chip SATA driver < resubmission >

2010-05-05 Thread Rupjyoti Sarmah
This patch enables the on-chip DWC SATA controller of the AppliedMicro processor 460EX. Signed-off-by: Rupjyoti Sarmah Signed-off-by: Mark Miesfeld Signed-off-by: Prodyut Hazarika --- arch/powerpc/boot/dts/canyonlands.dts |8 + drivers/ata/Kconfig |9 + drivers/ata/

Re: [PATCH] 460EX on-chip SATA driver < resubmission : 02>

2010-04-07 Thread Stefan Roese
On Wednesday 07 April 2010 09:41:56 Benjamin Herrenschmidt wrote: > BTW. Stefan mentioned earlier that they had some fixes for that driver > in the Denx tree. Are those fixes now included in that variant ? Yes, from a first scan the fix I was referring to seems to be included. Cheers, Stefan

RE: [PATCH] 460EX on-chip SATA driver < resubmission : 02>

2010-04-07 Thread Rupjyoti Sarmah
...@vger.kernel.org; s...@denx.de; linuxppc-...@ozlabs.org Subject: Re: [PATCH] 460EX on-chip SATA driver < resubmission : 02> On 04/06/2010 07:41 AM, Rupjyoti Sarmah wrote: General comment: remove "inline" and let the compiler select those functions that need it. > +struct

Re: [PATCH] 460EX on-chip SATA driver < resubmission : 02>

2010-04-07 Thread Benjamin Herrenschmidt
On Tue, 2010-04-06 at 11:16 -0400, Jeff Garzik wrote: > > +static irqreturn_t dma_dwc_interrupt(int irq, void *hsdev_instance) > > +{ > > + int chan; > > + u32 tfr_reg, err_reg; > > + > > + struct sata_dwc_device *hsdev = > > + (struct sata_dwc_device *) hsdev_instance; > >

Re: [PATCH] 460EX on-chip SATA driver < resubmission : 02>

2010-04-06 Thread Jeff Garzik
On 04/06/2010 07:41 AM, Rupjyoti Sarmah wrote: General comment: remove "inline" and let the compiler select those functions that need it. +struct sata_dwc_host_priv { + + void __iomem *scr_addr_sstatus; + u32 sata_dwc_sactive_issued; + u32 sata_dwc_sactive_queued; +

Re: [PATCH] 460EX on-chip SATA driver < resubmission : 01>

2010-03-17 Thread Jeff Garzik
On 03/17/2010 08:03 AM, Stefan Roese wrote: Hi Rup, On Wednesday 17 March 2010 05:23:16 Rupjyoti Sarmah wrote: This patch enables the on-chip DWC SATA controller of the AppliedMicro processor 460EX. Apart from the other comments, did you take a look at the latest version of this driver in our

Re: [PATCH] 460EX on-chip SATA driver < resubmission : 01>

2010-03-17 Thread Stefan Roese
Hi Rup, On Wednesday 17 March 2010 05:23:16 Rupjyoti Sarmah wrote: > This patch enables the on-chip DWC SATA controller of the AppliedMicro > processor 460EX. Apart from the other comments, did you take a look at the latest version of this driver in our linux-2.6-denx repository? We did some wor

RE: [PATCH] 460EX on-chip SATA driver < resubmission : 01>

2010-03-16 Thread Rupjyoti Sarmah
rmah; linuxppc-...@ozlabs.org; Rupjyoti Sarmah; linux-ker...@vger.kernel.org Subject: Re: [PATCH] 460EX on-chip SATA driver < resubmission : 01> Hi, Just a couple of quick points ... On Tue, 16 Mar 2010 21:23:16 -0700 "Rupjyoti Sarmah" wrote: > > This patch enables the on-chip

Re: [PATCH] 460EX on-chip SATA driver < resubmission : 01>

2010-03-16 Thread Stephen Rothwell
Hi, Just a couple of quick points ... On Tue, 16 Mar 2010 21:23:16 -0700 "Rupjyoti Sarmah" wrote: > > This patch enables the on-chip DWC SATA controller of the AppliedMicro > processor 460EX. > > Signed-off-by: Rupjyoti Sarmah ,Mark Miesfeld > , > Prodyut Hazarika Please put one Signed-off-b