Hi Liam,
On Thu, 30 Jan 2025 at 16:17, Liam R. Howlett wrote:
> * Geert Uytterhoeven [250130 09:25]:
> > On Thu, 30 Jan 2025 at 15:06, Liam R. Howlett
> > wrote:
> > > > > it is to get m68k to build, you should probably know how to read a
> > > > > makefile.
> > > >
> > > > Like all other kern
On Wed, 29 Jan 2025 16:28:32 -0500 Tamir Duberstein wrote:
> > How are grammar corrections going to the right person (but not the
> > mailing list) while an entire conversion to kunit is not [1]?
>
> Very simple: the tests are not properly included in MAINTAINERS. I
> sent
> https://lore.kernel
* Geert Uytterhoeven [250130 08:26]:
> Hi Liam,
>
> On Thu, 30 Jan 2025 at 13:52, Liam R. Howlett wrote:
> > * Geert Uytterhoeven [250130 03:21]:
> > > On Wed, 29 Jan 2025 at 23:26, Liam R. Howlett
> > > wrote:
> > > > I've never used the kunit testing of xarray and have used the userspace
>
* Geert Uytterhoeven [250130 09:25]:
> Hi Liam,
Hi Geert,
I'd like to say sorry for getting upset about this.
>
> On Thu, 30 Jan 2025 at 15:06, Liam R. Howlett wrote:
> >
> > I'll await your patch to link all this together. Please Cc the authors.
>
> I gave it a try for kselftests a few yea
On Thu, Jan 30, 2025 at 03:38:36PM +0100, Geert Uytterhoeven wrote:
> Hi Lorenzo,
>
> On Thu, 30 Jan 2025 at 15:09, Lorenzo Stoakes
> wrote:
> > Having written a ton of test code, I've unfortunately encountered a lot of
> > this sort of push-back and it's HUGELY off-putting. Writing test code
> >
Hi Lorenzo,
On Thu, 30 Jan 2025 at 15:09, Lorenzo Stoakes
wrote:
> Having written a ton of test code, I've unfortunately encountered a lot of
> this sort of push-back and it's HUGELY off-putting. Writing test code
> should be ENCOURAGED not litigated against.
I am not discouraging nor pushing ba
Hi Liam,
On Thu, 30 Jan 2025 at 15:06, Liam R. Howlett wrote:
> * Geert Uytterhoeven [250130 08:26]:
> > On Thu, 30 Jan 2025 at 13:52, Liam R. Howlett
> > wrote:
> > > * Geert Uytterhoeven [250130 03:21]:
> > > > On Wed, 29 Jan 2025 at 23:26, Liam R. Howlett
> > > > wrote:
> > > > > I've ne
On Thu, Jan 30, 2025 at 09:21:12AM +0100, Geert Uytterhoeven wrote:
> The long and obscure command line is a red herring: a simple
> "modprobe test_xarray" is all it takes...
That's all I've ever done. I'm confused/annoyed by all this "let's
wrap everything up in some complex and obscure new thin
Geert,
Having written a ton of test code, I've unfortunately encountered a lot of
this sort of push-back and it's HUGELY off-putting. Writing test code
should be ENCOURAGED not litigated against.
The truth is far too little kernel code is tested to any degree, and this
is part of why.
On kunit c
Hi Liam,
On Thu, 30 Jan 2025 at 13:52, Liam R. Howlett wrote:
> * Geert Uytterhoeven [250130 03:21]:
> > On Wed, 29 Jan 2025 at 23:26, Liam R. Howlett
> > wrote:
> > > I've never used the kunit testing of xarray and have used the userspace
> > > testing instead, so I can't speak to the obscure
* Geert Uytterhoeven [250130 03:21]:
> Hi Liam,
>
> On Wed, 29 Jan 2025 at 23:26, Liam R. Howlett wrote:
> > I've never used the kunit testing of xarray and have used the userspace
> > testing instead, so I can't speak to the obscure invocation as both
> > commands seem insanely long and obscure
Hi Liam,
On Wed, 29 Jan 2025 at 23:26, Liam R. Howlett wrote:
> I've never used the kunit testing of xarray and have used the userspace
> testing instead, so I can't speak to the obscure invocation as both
> commands seem insanely long and obscure to me.
The long and obscure command line is a re
On Wed, Jan 29, 2025 at 6:11 PM Matthew Wilcox wrote:
>
> On Wed, Jan 29, 2025 at 06:08:22PM -0500, Tamir Duberstein wrote:
> > The whole point of tools is to liberate stupid humans' brains like
> > mine from mundane tasks like working out who to email. The tool wasn't
> > wrong; it did exactly wh
On Wed, Jan 29, 2025 at 6:02 PM Matthew Wilcox wrote:
>
> On Wed, Jan 29, 2025 at 05:33:06PM -0500, Tamir Duberstein wrote:
> > > $ ./scripts/get_maintainer.pl --git lib/xarray.c
> > > Matthew Wilcox
> > > (supporter:XARRAY,commit_signer:1/3=33%,authored:1/3=33%,added_lines:19/52=37%,removed_li
On Wed, Jan 29, 2025 at 06:08:22PM -0500, Tamir Duberstein wrote:
> The whole point of tools is to liberate stupid humans' brains like
> mine from mundane tasks like working out who to email. The tool wasn't
> wrong; it did exactly what you told it to do in your MAINTAINERS
> entry.
Tools do get t
On Wed, Jan 29, 2025 at 05:33:06PM -0500, Tamir Duberstein wrote:
> > $ ./scripts/get_maintainer.pl --git lib/xarray.c
> > Matthew Wilcox
> > (supporter:XARRAY,commit_signer:1/3=33%,authored:1/3=33%,added_lines:19/52=37%,removed_lines:4/23=17%)
> > Andrew Morton (supporter:LIBRARY
> > CODE,com
On Wed, Jan 29, 2025 at 5:26 PM Liam R. Howlett wrote:
>
> * Tamir Duberstein [250129 16:29]:
> > On Wed, Jan 29, 2025 at 4:26 PM Liam R. Howlett
> > wrote:
> > >
> > > * Sidhartha Kumar [250129 16:02]:
> > > > + Liam, Matthew
> > >
> > > + linux-mm
> > >
> > > Thank you Sid.
> > >
> > > >
> >
* Tamir Duberstein [250129 16:29]:
> On Wed, Jan 29, 2025 at 4:26 PM Liam R. Howlett
> wrote:
> >
> > * Sidhartha Kumar [250129 16:02]:
> > > + Liam, Matthew
> >
> > + linux-mm
> >
> > Thank you Sid.
> >
> > >
> > > Hello,
> > >
> > > I believe this patch needs to be reverted for now as it brea
+ Liam, Matthew
Hello,
I believe this patch needs to be reverted for now as it breaks the
user-space build of /tools/testing/radix-tree with:
In file included from xarray.c:11:
../../../lib/test_xarray.c:9:10: fatal error: kunit/test.h: No such file
or directory
9 | #include
|
On Wed, Jan 29, 2025 at 4:26 PM Liam R. Howlett wrote:
>
> * Sidhartha Kumar [250129 16:02]:
> > + Liam, Matthew
>
> + linux-mm
>
> Thank you Sid.
>
> >
> > Hello,
> >
> > I believe this patch needs to be reverted for now as it breaks the
> > user-space build of /tools/testing/radix-tree with:
>
* Sidhartha Kumar [250129 16:02]:
> + Liam, Matthew
+ linux-mm
Thank you Sid.
>
> Hello,
>
> I believe this patch needs to be reverted for now as it breaks the
> user-space build of /tools/testing/radix-tree with:
>
> In file included from xarray.c:11:
> ../../../lib/test_xarray.c:9:10: fata
Minimally rewrite the XArray unit tests to use kunit. This integrates
nicely with existing kunit tools which produce nicer human-readable
output compared to the existing machinery.
Running the xarray tests before this change requires an obscure
invocation
```
tools/testing/kunit/kunit.py run --ar
22 matches
Mail list logo
