Re: [PATCH] usb:gadget: use min_t() macro instead of min()

Hi, On Mon, Jun 13, 2011 at 03:03:44PM -0400, Alan Stern wrote: > > > The change I suggested involved replacing two typecasts with a single > > > min_t. All (or almost all) the places this patch touches currently > > > contain only one typecast, so the motivation for changing them is a lot > > >

RE: [PATCH] usb:gadget: use min_t() macro instead of min()

On Mon, 13 Jun 2011, Tanya Brokhman wrote: > > > > The change I suggested involved replacing two typecasts with a single > > min_t. All (or almost all) the places this patch touches currently > > contain only one typecast, so the motivation for changing them is a lot > > weaker. > > > You're ri

RE: [PATCH] usb:gadget: use min_t() macro instead of min()

> > The change I suggested involved replacing two typecasts with a single > min_t. All (or almost all) the places this patch touches currently > contain only one typecast, so the motivation for changing them is a lot > weaker. > You're right. So what's the final call on this one? Do you think it

RE: [PATCH] usb:gadget: use min_t() macro instead of min()

On Mon, 13 Jun 2011, Tanya Brokhman wrote: > > > > On Sun, Jun 12, 2011 at 02:14:46PM +0300, Tatyana Brokhman wrote: > > > Signed-off-by: Tatyana Brokhman > > > > I need a sensible commit log for this. Why do we need to change all > > min() to min_t() ? > > > > Actually, Alan asked me to make

Re: [PATCH] usb:gadget: use min_t() macro instead of min()

Hi, On Mon, Jun 13, 2011 at 02:52:34PM +0300, Tanya Brokhman wrote: > > On Sun, Jun 12, 2011 at 02:14:46PM +0300, Tatyana Brokhman wrote: > > > Signed-off-by: Tatyana Brokhman > > > > I need a sensible commit log for this. Why do we need to change all > > min() to min_t() ? > > > > Actually, A

RE: [PATCH] usb:gadget: use min_t() macro instead of min()

> > On Sun, Jun 12, 2011 at 02:14:46PM +0300, Tatyana Brokhman wrote: > > Signed-off-by: Tatyana Brokhman > > I need a sensible commit log for this. Why do we need to change all > min() to min_t() ? > Actually, Alan asked me to make this change in one place in dummy_hcd. I wasn't aware of the

Re: [PATCH] usb:gadget: use min_t() macro instead of min()

Hi, On Sun, Jun 12, 2011 at 02:14:46PM +0300, Tatyana Brokhman wrote: > Signed-off-by: Tatyana Brokhman I need a sensible commit log for this. Why do we need to change all min() to min_t() ? -- balbi signature.asc Description: Digital signature __

[PATCH] usb:gadget: use min_t() macro instead of min()

Signed-off-by: Tatyana Brokhman --- drivers/usb/gadget/composite.c | 16 drivers/usb/gadget/dummy_hcd.c |2 +- drivers/usb/gadget/f_fs.c |6 +++--- drivers/usb/gadget/f_mass_storage.c | 20 ++-- drivers/usb/gadget/file_storage.c