Re: [PATCH] uninorth agp: don't mark module parameter __devinit

2008-10-30 Thread Michel Dänzer
On Thu, 2008-10-30 at 09:45 +0100, Johannes Berg wrote: > Michel Dänzer wrote: > > >> Can uninorth_fetch_size be marked __devinit then? > > > > I'm not sure, and none of the other AGP backend drivers seems to do > > so... > > Well, either it can, or marking "aperture" is wrong, no? Makes sense,

Re: [PATCH] uninorth agp: don't mark module parameter __devinit

2008-10-30 Thread Johannes Berg
Michel Dänzer wrote: >> Can uninorth_fetch_size be marked __devinit then? > > I'm not sure, and none of the other AGP backend drivers seems to do > so... Well, either it can, or marking "aperture" is wrong, no? johannes ___ Linuxppc-dev mailing list Li

Re: [PATCH] uninorth agp: don't mark module parameter __devinit

2008-10-29 Thread Michel Dänzer
On Wed, 2008-10-29 at 13:12 +0100, Johannes Berg wrote: > On Wed, 2008-10-29 at 13:09 +0100, Michel Dänzer wrote: > > On Wed, 2008-10-29 at 03:11 +0100, Johannes Berg wrote: > > > A module parameter can possibly be shown via sysfs, which isn't a good > > > idea if the section has been removed, so r

Re: [PATCH] uninorth agp: don't mark module parameter __devinit

2008-10-29 Thread Johannes Berg
On Wed, 2008-10-29 at 13:09 +0100, Michel Dänzer wrote: > On Wed, 2008-10-29 at 03:11 +0100, Johannes Berg wrote: > > A module parameter can possibly be shown via sysfs, which isn't a good > > idea if the section has been removed, so remove the __devinit > > annotation. > > Under what circumstance

Re: [PATCH] uninorth agp: don't mark module parameter __devinit

2008-10-29 Thread Michel Dänzer
On Wed, 2008-10-29 at 03:11 +0100, Johannes Berg wrote: > A module parameter can possibly be shown via sysfs, which isn't a good > idea if the section has been removed, so remove the __devinit > annotation. Under what circumstances could it be shown in sysfs? -- Earthling Michel Dänzer

[PATCH] uninorth agp: don't mark module parameter __devinit

2008-10-29 Thread Johannes Berg
A module parameter can possibly be shown via sysfs, which isn't a good idea if the section has been removed, so remove the __devinit annotation. Signed-off-by: Johannes Berg <[EMAIL PROTECTED]> --- Also fixes a section mismatch warning. --- everything.orig/drivers/char/agp/uninorth-agp.c 2008