Re: [PATCH] tracing: Fix TRACING_SUPPORT dependency

2009-03-23 Thread Benjamin Herrenschmidt
> > Weird, there's no lockdep support? > > *ashamed*: apparently no such support currently exist for PPC32. ;-) Actually there is a patch that's been floating around (from Dale Farnsworth) for adding irqtrace/lockdep to ppc32 but it seems to be buggy :-) IE, it causes crashes and I haven't had a

Re: [PATCH] tracing: Fix TRACING_SUPPORT dependency for PPC32

2009-03-23 Thread Steven Rostedt
On Tue, 24 Mar 2009, Anton Vorontsov wrote: > commit 40ada30f9621fbd831ac2437b9a2a399aa ("tracing: clean up menu"), > despite the "clean up" in its purpose, introduced a behavioural > change for Kconfig symbols: we no longer able to select tracing > support on PPC32 (because IRQFLAGS_SUPPORT isn'

[PATCH] tracing: Fix TRACING_SUPPORT dependency for PPC32

2009-03-23 Thread Anton Vorontsov
commit 40ada30f9621fbd831ac2437b9a2a399aa ("tracing: clean up menu"), despite the "clean up" in its purpose, introduced a behavioural change for Kconfig symbols: we no longer able to select tracing support on PPC32 (because IRQFLAGS_SUPPORT isn't yet implemented). The IRQFLAGS_SUPPORT is not manda

Re: [PATCH] tracing: Fix TRACING_SUPPORT dependency

2009-03-21 Thread Ingo Molnar
* Steven Rostedt wrote: > > On Sat, 21 Mar 2009, Steven Rostedt wrote: > > > > Since we know that's not an issue with PPC32, perhaps we should add (I > > hate to do this)... > > > > > > depends on TRACE_IRQFLAGS_SUPPORT || PPC32 > > > > And document that the "|| PPC32" should go when P

Re: [PATCH] tracing: Fix TRACING_SUPPORT dependency

2009-03-21 Thread Steven Rostedt
On Sat, 21 Mar 2009, Steven Rostedt wrote: > > Since we know that's not an issue with PPC32, perhaps we should add (I > hate to do this)... > > > depends on TRACE_IRQFLAGS_SUPPORT || PPC32 > > And document that the "|| PPC32" should go when PowerPC32 gets its act > together. :-/ Note,

Re: [PATCH] tracing: Fix TRACING_SUPPORT dependency

2009-03-21 Thread Steven Rostedt
On Sat, 21 Mar 2009, Ingo Molnar wrote: > > > > > > Hm, do all the tracers even compile on ppc32 with your patch? > > > > > > We had periodic build failures on weird, unmaintained architectures > > > that had no irqflags-tracing support and hence didnt know the > > > raw_irqs_save/restore prim

Re: [PATCH] tracing: Fix TRACING_SUPPORT dependency

2009-03-21 Thread Ingo Molnar
* Steven Rostedt wrote: > > On Sat, 21 Mar 2009, Ingo Molnar wrote: > > > > > * Anton Vorontsov wrote: > > > > > On Fri, Mar 20, 2009 at 08:57:43PM +0100, Ingo Molnar wrote: > > > > > > > > * Anton Vorontsov wrote: > > > > > > > > > On Fri, Mar 20, 2009 at 08:04:28PM +0100, Ingo Molnar w

Re: [PATCH] tracing: Fix TRACING_SUPPORT dependency

2009-03-21 Thread Steven Rostedt
On Sat, 21 Mar 2009, Ingo Molnar wrote: > > * Anton Vorontsov wrote: > > > On Fri, Mar 20, 2009 at 08:57:43PM +0100, Ingo Molnar wrote: > > > > > > * Anton Vorontsov wrote: > > > > > > > On Fri, Mar 20, 2009 at 08:04:28PM +0100, Ingo Molnar wrote: > > > > > > > > > > * Anton Vorontsov wro

Re: [PATCH] tracing: Fix TRACING_SUPPORT dependency

2009-03-21 Thread Ingo Molnar
* Anton Vorontsov wrote: > On Fri, Mar 20, 2009 at 08:57:43PM +0100, Ingo Molnar wrote: > > > > * Anton Vorontsov wrote: > > > > > On Fri, Mar 20, 2009 at 08:04:28PM +0100, Ingo Molnar wrote: > > > > > > > > * Anton Vorontsov wrote: > > > > > > > > > commit 40ada30f9621fbd831ac2437b9a2a399

Re: [PATCH] tracing: Fix TRACING_SUPPORT dependency

2009-03-20 Thread Steven Rostedt
Ug, My Red Hat email was not being updated. I totally missed this thread. On Fri, 2009-03-20 at 20:57 +0100, Ingo Molnar wrote: > * Anton Vorontsov wrote: > > > On Fri, Mar 20, 2009 at 08:04:28PM +0100, Ingo Molnar wrote: > > > > > > * Anton Vorontsov wrote: > > > > > > > commit 40ada30f9621

Re: [PATCH] tracing: Fix TRACING_SUPPORT dependency

2009-03-20 Thread Anton Vorontsov
On Fri, Mar 20, 2009 at 08:57:43PM +0100, Ingo Molnar wrote: > > * Anton Vorontsov wrote: > > > On Fri, Mar 20, 2009 at 08:04:28PM +0100, Ingo Molnar wrote: > > > > > > * Anton Vorontsov wrote: > > > > > > > commit 40ada30f9621fbd831ac2437b9a2a399aad34b00 ("tracing: clean > > > > up menu"),

Re: [PATCH] tracing: Fix TRACING_SUPPORT dependency

2009-03-20 Thread Ingo Molnar
* Anton Vorontsov wrote: > On Fri, Mar 20, 2009 at 08:04:28PM +0100, Ingo Molnar wrote: > > > > * Anton Vorontsov wrote: > > > > > commit 40ada30f9621fbd831ac2437b9a2a399aad34b00 ("tracing: clean > > > up menu"), despite the "clean up" in its purpose, introduced > > > behavioural change for

Re: [PATCH] tracing: Fix TRACING_SUPPORT dependency

2009-03-20 Thread Anton Vorontsov
On Fri, Mar 20, 2009 at 08:04:28PM +0100, Ingo Molnar wrote: > > * Anton Vorontsov wrote: > > > commit 40ada30f9621fbd831ac2437b9a2a399aad34b00 ("tracing: clean > > up menu"), despite the "clean up" in its purpose, introduced > > behavioural change for Kconfig symbols: we no longer able to >

Re: [PATCH] tracing: Fix TRACING_SUPPORT dependency

2009-03-20 Thread Ingo Molnar
* Anton Vorontsov wrote: > commit 40ada30f9621fbd831ac2437b9a2a399aad34b00 ("tracing: clean > up menu"), despite the "clean up" in its purpose, introduced > behavioural change for Kconfig symbols: we no longer able to > select tracing support on PPC32 (because IRQFLAGS_SUPPORT isn't > yet im

[PATCH] tracing: Fix TRACING_SUPPORT dependency

2009-03-20 Thread Anton Vorontsov
commit 40ada30f9621fbd831ac2437b9a2a399aad34b00 ("tracing: clean up menu"), despite the "clean up" in its purpose, introduced behavioural change for Kconfig symbols: we no longer able to select tracing support on PPC32 (because IRQFLAGS_SUPPORT isn't yet implemented). The IRQFLAGS_SUPPORT is not m