Re: [PATCH] tools/perf/tests/expr: Make the system_tsc_freq test only for intel

> On 3 Dec 2024, at 11:46 PM, Namhyung Kim wrote: > > Hello, > > On Fri, Nov 08, 2024 at 10:50:10AM +0530, Athira Rajeev wrote: >> >> >>> On 7 Nov 2024, at 7:26 PM, Leo Yan wrote: >>> >>> Hi Athira, >>> >>> On Wed, Nov 06, 2024 at 03:04:57PM +0530, Athira Rajeev wrote: >>> >>> [...] >>>

Re: [PATCH] tools/perf/tests/expr: Make the system_tsc_freq test only for intel

Hello, On Fri, Nov 08, 2024 at 10:50:10AM +0530, Athira Rajeev wrote: > > > > On 7 Nov 2024, at 7:26 PM, Leo Yan wrote: > > > > Hi Athira, > > > > On Wed, Nov 06, 2024 at 03:04:57PM +0530, Athira Rajeev wrote: > > > > [...] > > > >>> Hi Athira, > >>> > >>> sorry for the breakage and thank

Re: [PATCH] tools/perf/tests/expr: Make the system_tsc_freq test only for intel

On Tue, Dec 03, 2024 at 10:42:45AM -0800, Namhyung Kim wrote: > On Tue, Dec 03, 2024 at 10:16:06AM -0800, Namhyung Kim wrote: > > Hello, > > > > On Fri, Nov 08, 2024 at 10:50:10AM +0530, Athira Rajeev wrote: > > > > > > > > > > On 7 Nov 2024, at 7:26 PM, Leo Yan wrote: > > > > > > > > Hi Athir

Re: [PATCH] tools/perf/tests/expr: Make the system_tsc_freq test only for intel

On Tue, Dec 03, 2024 at 10:16:06AM -0800, Namhyung Kim wrote: > Hello, > > On Fri, Nov 08, 2024 at 10:50:10AM +0530, Athira Rajeev wrote: > > > > > > > On 7 Nov 2024, at 7:26 PM, Leo Yan wrote: > > > > > > Hi Athira, > > > > > > On Wed, Nov 06, 2024 at 03:04:57PM +0530, Athira Rajeev wrote: >

Re: [PATCH] tools/perf/tests/expr: Make the system_tsc_freq test only for intel

> On 7 Nov 2024, at 7:26 PM, Leo Yan wrote: > > Hi Athira, > > On Wed, Nov 06, 2024 at 03:04:57PM +0530, Athira Rajeev wrote: > > [...] > >>> Hi Athira, >>> >>> sorry for the breakage and thank you for the detailed explanation. As >>> the code will run on AMD I think your change will break

Re: [PATCH] tools/perf/tests/expr: Make the system_tsc_freq test only for intel

Hi Athira, On Wed, Nov 06, 2024 at 03:04:57PM +0530, Athira Rajeev wrote: [...] > > Hi Athira, > > > > sorry for the breakage and thank you for the detailed explanation. As > > the code will run on AMD I think your change will break that - . It is > > probably safest to keep the ".. else { .." f

Re: [PATCH] tools/perf/tests/expr: Make the system_tsc_freq test only for intel

> On 5 Nov 2024, at 2:14 AM, Ian Rogers wrote: > > On Sun, Nov 3, 2024 at 8:17 PM Athira Rajeev > wrote: >> >> >> >>> On 30 Oct 2024, at 5:29 AM, Namhyung Kim wrote: >>> >>> Hello, >>> >>> On Tue, Oct 22, 2024 at 07:31:56PM +0530, Athira Rajeev wrote: The "Simple expression parser"

Re: [PATCH] tools/perf/tests/expr: Make the system_tsc_freq test only for intel

On Sun, Nov 3, 2024 at 8:17 PM Athira Rajeev wrote: > > > > > On 30 Oct 2024, at 5:29 AM, Namhyung Kim wrote: > > > > Hello, > > > > On Tue, Oct 22, 2024 at 07:31:56PM +0530, Athira Rajeev wrote: > >> The "Simple expression parser" test fails on powerpc > >> as below: > >> > >> parsing metric: #s

Re: [PATCH] tools/perf/tests/expr: Make the system_tsc_freq test only for intel

> On 30 Oct 2024, at 5:29 AM, Namhyung Kim wrote: > > Hello, > > On Tue, Oct 22, 2024 at 07:31:56PM +0530, Athira Rajeev wrote: >> The "Simple expression parser" test fails on powerpc >> as below: >> >> parsing metric: #system_tsc_freq >> Unrecognized literal '#system_tsc_freq'literal: #syst

Re: [PATCH] tools/perf/tests/expr: Make the system_tsc_freq test only for intel

Hello, On Tue, Oct 22, 2024 at 07:31:56PM +0530, Athira Rajeev wrote: > The "Simple expression parser" test fails on powerpc > as below: > > parsing metric: #system_tsc_freq > Unrecognized literal '#system_tsc_freq'literal: #system_tsc_freq = nan > syntax error > FAILED tests/expr.c:247 #syst

[PATCH] tools/perf/tests/expr: Make the system_tsc_freq test only for intel

The "Simple expression parser" test fails on powerpc as below: parsing metric: #system_tsc_freq Unrecognized literal '#system_tsc_freq'literal: #system_tsc_freq = nan syntax error FAILED tests/expr.c:247 #system_tsc_freq end(-1) 7: Simple expression parser : FAILED! In the test,