Re: [PATCH] the wrong variable checked after request_irq()

2007-07-15 Thread Benjamin Herrenschmidt
On Sun, 2007-07-15 at 23:02 +0100, Al Viro wrote: > On Mon, Jul 16, 2007 at 07:40:38AM +1000, Benjamin Herrenschmidt wrote: > > On Sun, 2007-07-15 at 20:59 +0100, Al Viro wrote: > > > Signed-off-by: Al Viro <[EMAIL PROTECTED]> > > > > Acked-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> > > > > O

Re: [PATCH] the wrong variable checked after request_irq()

2007-07-15 Thread Al Viro
On Mon, Jul 16, 2007 at 07:40:38AM +1000, Benjamin Herrenschmidt wrote: > On Sun, 2007-07-15 at 20:59 +0100, Al Viro wrote: > > Signed-off-by: Al Viro <[EMAIL PROTECTED]> > > Acked-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> > > Out of curiosity, how did you pick it up ? You have some automate

Re: [PATCH] the wrong variable checked after request_irq()

2007-07-15 Thread Benjamin Herrenschmidt
On Sun, 2007-07-15 at 20:59 +0100, Al Viro wrote: > Signed-off-by: Al Viro <[EMAIL PROTECTED]> Acked-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> Out of curiosity, how did you pick it up ? You have some automated tool to catch that (or sparse changes) or you just did -lots- of code inspection ?

[PATCH] the wrong variable checked after request_irq()

2007-07-15 Thread Al Viro
Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- arch/powerpc/platforms/pseries/setup.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/platforms/pseries/setup.c b/arch/powerpc/platforms/pseries/setup.c index 470db6e..a031d99 100644 --- a/arch/powerpc/platfor