Re: [PATCH] srcu: Isolate srcu sections using CONFIG_SRCU

2014-12-30 Thread Scott Wood
On Mon, 2014-12-29 at 23:32 -0500, Pranith Kumar wrote: > On Mon, Dec 29, 2014 at 5:03 AM, Martin Schwidefsky > wrote: > > On Sat, 27 Dec 2014 12:17:43 -0500 > > Pranith Kumar wrote: > > > >> @@ -65,10 +65,13 @@ > >> #include > >> #include > >> #include > >> -#include > >> #include > >>

Re: [PATCH] srcu: Isolate srcu sections using CONFIG_SRCU

2014-12-29 Thread Pranith Kumar
On Mon, Dec 29, 2014 at 6:05 PM, Scott Wood wrote: > On Sat, 2014-12-27 at 12:17 -0500, Pranith Kumar wrote: >> Isolate the SRCU functions and data structures within CONFIG_SRCU so that >> there >> is a compile time failure if srcu is used when not enabled. This was decided >> to >> be better th

Re: [PATCH] srcu: Isolate srcu sections using CONFIG_SRCU

2014-12-29 Thread Pranith Kumar
On Mon, Dec 29, 2014 at 5:03 AM, Martin Schwidefsky wrote: > On Sat, 27 Dec 2014 12:17:43 -0500 > Pranith Kumar wrote: > >> @@ -65,10 +65,13 @@ >> #include >> #include >> #include >> -#include >> #include >> #include >> >> +#if IS_ENABLED(CONFIG_KVM) >> +#include >> +#endif >> + >> #

Re: [PATCH] srcu: Isolate srcu sections using CONFIG_SRCU

2014-12-29 Thread Scott Wood
On Sat, 2014-12-27 at 12:17 -0500, Pranith Kumar wrote: > Isolate the SRCU functions and data structures within CONFIG_SRCU so that > there > is a compile time failure if srcu is used when not enabled. This was decided > to > be better than waiting until link time for a failure to occur. Yes, fa

Re: [PATCH] srcu: Isolate srcu sections using CONFIG_SRCU

2014-12-29 Thread Martin Schwidefsky
On Sat, 27 Dec 2014 12:17:43 -0500 Pranith Kumar wrote: > @@ -65,10 +65,13 @@ > #include > #include > #include > -#include > #include > #include > > +#if IS_ENABLED(CONFIG_KVM) > +#include > +#endif > + > #ifdef DEBUG > #define DBG(fmt...) udbg_printf(fmt) > #else I always cringe

[PATCH] srcu: Isolate srcu sections using CONFIG_SRCU

2014-12-27 Thread Pranith Kumar
Isolate the SRCU functions and data structures within CONFIG_SRCU so that there is a compile time failure if srcu is used when not enabled. This was decided to be better than waiting until link time for a failure to occur. There are places which include kvm headers and utilize kvm data structures