Re: [PATCH] spufs raises two exceptions

2012-03-07 Thread Arnd Bergmann
On Wednesday 07 March 2012, Al Viro wrote: > > No it's not, it all goes together. spufs_create_context() always > > unlocked & dropped the dentry before returning, so I assumed the > > lock had to be dropped before fsnotify. > > > > Note that if the problem is that the lock has to be dropped befor

Re: [PATCH] spufs raises two exceptions

2012-03-07 Thread Al Viro
> No it's not, it all goes together. spufs_create_context() always > unlocked & dropped the dentry before returning, so I assumed the > lock had to be dropped before fsnotify. > > Note that if the problem is that the lock has to be dropped before > spu_forget(), then we should indeed move it back

Re: [PATCH] spufs raises two exceptions

2012-03-07 Thread Benjamin Herrenschmidt
> > diff --git a/arch/powerpc/platforms/cell/spufs/inode.c > > b/arch/powerpc/platforms/cell/spufs/inode.c > > index d4a094c..63b4e43 100644 > > --- a/arch/powerpc/platforms/cell/spufs/inode.c > > +++ b/arch/powerpc/platforms/cell/spufs/inode.c > > @@ -454,19 +454,16 @@ spufs_create_context(struc

Re: [PATCH] spufs raises two exceptions

2012-03-07 Thread Arnd Bergmann
On Wednesday 07 March 2012, Benjamin Herrenschmidt wrote: > On Wed, 2012-03-07 at 14:49 +1100, Benjamin Herrenschmidt wrote: > > On Tue, 2012-03-06 at 10:26 +0100, masterzorag wrote: > > > I'm running my test program, it uses all available spus to compute via > > > OpenCL > > > kernel 3.2.5 on a p

Re: [PATCH] spufs raises two exceptions

2012-03-06 Thread Benjamin Herrenschmidt
On Wed, 2012-03-07 at 14:49 +1100, Benjamin Herrenschmidt wrote: > On Tue, 2012-03-06 at 10:26 +0100, masterzorag wrote: > > I'm running my test program, it uses all available spus to compute via > > OpenCL > > kernel 3.2.5 on a ps3 > > even on testing spu directly, it crashes > > I think the pat

Re: [PATCH] spufs raises two exceptions

2012-03-06 Thread Benjamin Herrenschmidt
On Tue, 2012-03-06 at 10:26 +0100, masterzorag wrote: > I'm running my test program, it uses all available spus to compute via > OpenCL > kernel 3.2.5 on a ps3 > even on testing spu directly, it crashes I think the patch is not 100% right yet. Looking at the code, we have a real mess of who gets

[PATCH] spufs raises two exceptions

2012-03-06 Thread masterzorag
I'm running my test program, it uses all available spus to compute via OpenCL kernel 3.2.5 on a ps3 even on testing spu directly, it crashes = [ BUG: bad unlock balance detected! ] - test/1067 is trying to release lock (&sb