Re: [PATCH] spi_mpc8xxx: issue with using definition of pram in Device Tree

2010-09-24 Thread Scott Wood
On Fri, 24 Sep 2010 11:57:40 +0400 Anton Vorontsov wrote: > Doesn't explain why that worked on MPC8272 (CPM2) and MPC8560 > (also CPM2) machines though. But here's my guess (I no longer > have these boards to test it): > > On 8272 I used this node: > > + s...@4c0 { > +

Re: [PATCH] spi_mpc8xxx: issue with using definition of pram in Device Tree

2010-09-24 Thread Scott Wood
On Fri, 24 Sep 2010 01:10:06 -0600 Grant Likely wrote: > On Thu, Sep 16, 2010 at 09:05:03AM +0200, christophe leroy wrote: > > This patch applies to 2.6.34.7 and 2.6.35.4 > > It fixes an issue during the probe for CPM1 with definition of parameter > > ram from DTS > > > > Signed-off-by: christo

Re: [PATCH] spi_mpc8xxx: issue with using definition of pram in Device Tree

2010-09-24 Thread Anton Vorontsov
Hello, On Fri, Sep 24, 2010 at 09:20:27AM +0200, LEROY Christophe wrote: > The issue is that cpm_muram_alloc_fixed() allocates memory from the > general purpose muram area (from 0x0 to 0x1bff). > Here we need to return a pointer to the parameter RAM, which is > located somewhere starting at 0x1c00

Re: [PATCH] spi_mpc8xxx: issue with using definition of pram in Device Tree

2010-09-24 Thread LEROY Christophe
Hello, The issue is that cpm_muram_alloc_fixed() allocates memory from the general purpose muram area (from 0x0 to 0x1bff). Here we need to return a pointer to the parameter RAM, which is located somewhere starting at 0x1c00. It is not a dynamic allocation that is required here but only to po

Re: [PATCH] spi_mpc8xxx: issue with using definition of pram in Device Tree

2010-09-24 Thread Grant Likely
On Thu, Sep 16, 2010 at 09:05:03AM +0200, christophe leroy wrote: > This patch applies to 2.6.34.7 and 2.6.35.4 > It fixes an issue during the probe for CPM1 with definition of parameter ram > from DTS > > Signed-off-by: christophe leroy I'm sorry, I don't understand the fix from the given desc

[PATCH] spi_mpc8xxx: issue with using definition of pram in Device Tree

2010-09-16 Thread christophe leroy
This patch applies to 2.6.34.7 and 2.6.35.4 It fixes an issue during the probe for CPM1 with definition of parameter ram from DTS Signed-off-by: christophe leroy diff -urN b/drivers/spi/spi_mpc8xxx.c c/drivers/spi/spi_mpc8xxx.c --- b/drivers/spi/spi_mpc8xxx.c 2010-09-08 16:43:50.0 +0200