Re: [PATCH] spi/mpc52xx-spi: cleanups

2009-11-20 Thread Grant Likely
On Wed, Nov 18, 2009 at 2:58 AM, Wolfram Sang wrote: >> > -           rc |= request_irq(ms->irq1, mpc52xx_spi_irq, >> > IRQF_SAMPLE_RANDOM, >> > +           rc |= request_irq(ms->irq1, mpc52xx_spi_irq, 0, >> >                               "mpc5200-spi-spiF", ms); >> >> The "spiF" here is probabl

Re: [PATCH] spi/mpc52xx-spi: cleanups

2009-11-18 Thread Wolfram Sang
> > - rc |= request_irq(ms->irq1, mpc52xx_spi_irq, IRQF_SAMPLE_RANDOM, > > + rc |= request_irq(ms->irq1, mpc52xx_spi_irq, 0, > > "mpc5200-spi-spiF", ms); > > The "spiF" here is probably also a typo. Ack. Grant, if you think it is worth you may mod

Re: [PATCH] spi/mpc52xx-spi: cleanups

2009-11-17 Thread Luotao Fu
On Tue, Nov 17, 2009 at 03:31:08PM +0100, Wolfram Sang wrote: > - drop own, obsolete include-file > - drop IRQF_SAMPLE_RANDOM (deprecated feature) > - drop 'if' above kfree() > - typos, braces & whitespaces > > Signed-off-by: Wolfram Sang > Cc: Luotao Fu > Cc: Grant Likely acked-by: Luotao Fu

[PATCH] spi/mpc52xx-spi: cleanups

2009-11-17 Thread Wolfram Sang
- drop own, obsolete include-file - drop IRQF_SAMPLE_RANDOM (deprecated feature) - drop 'if' above kfree() - typos, braces & whitespaces Signed-off-by: Wolfram Sang Cc: Luotao Fu Cc: Grant Likely --- This goes ontop of Grant's test-branch. drivers/spi/mpc52xx_spi.c | 24 ++---