Re: [PATCH] slub: fix kernel BUG at mm/slub.c:1950!

2011-06-14 Thread Hugh Dickins
On Tue, 14 Jun 2011, Benjamin Herrenschmidt wrote: > On Mon, 2011-06-13 at 14:00 -0700, Hugh Dickins wrote: > > On Mon, Jun 13, 2011 at 1:34 PM, Pekka Enberg wrote: > > > On Mon, Jun 13, 2011 at 10:29 PM, Christoph Lameter > > > wrote: > > >> On Mon, 13 Jun 2011, Pekka Enberg wrote: > > >> > > >

Re: [PATCH] slub: fix kernel BUG at mm/slub.c:1950!

2011-06-13 Thread Benjamin Herrenschmidt
On Mon, 2011-06-13 at 14:00 -0700, Hugh Dickins wrote: > On Mon, Jun 13, 2011 at 1:34 PM, Pekka Enberg wrote: > > On Mon, Jun 13, 2011 at 10:29 PM, Christoph Lameter wrote: > >> On Mon, 13 Jun 2011, Pekka Enberg wrote: > >> > >>> > Hmmm.. The allocpercpu in alloc_kmem_cache_cpus should take care

Re: [PATCH] slub: fix kernel BUG at mm/slub.c:1950!

2011-06-13 Thread Pekka Enberg
On Mon, Jun 13, 2011 at 10:29 PM, Christoph Lameter wrote: > On Mon, 13 Jun 2011, Pekka Enberg wrote: > >> > Hmmm.. The allocpercpu in alloc_kmem_cache_cpus should take care of the >> > alignment. Uhh.. I see that a patch that removes the #ifdef CMPXCHG_LOCAL >> > was not applied? Pekka? >> >> Thi

Re: [PATCH] slub: fix kernel BUG at mm/slub.c:1950!

2011-06-13 Thread Pekka Enberg
On Mon, 2011-06-13 at 12:59 -0500, Christoph Lameter wrote: > On Sun, 12 Jun 2011, Hugh Dickins wrote: > > > 3.0-rc won't boot with SLUB on my PowerPC G5: kernel BUG at mm/slub.c:1950! > > Bisected to 1759415e630e "slub: Remove CONFIG_CMPXCHG_LOCAL ifdeffery". > > > > After giving myself a medal f

Re: [PATCH] slub: fix kernel BUG at mm/slub.c:1950!

2011-06-13 Thread Hugh Dickins
On Mon, Jun 13, 2011 at 1:34 PM, Pekka Enberg wrote: > On Mon, Jun 13, 2011 at 10:29 PM, Christoph Lameter wrote: >> On Mon, 13 Jun 2011, Pekka Enberg wrote: >> >>> > Hmmm.. The allocpercpu in alloc_kmem_cache_cpus should take care of the >>> > alignment. Uhh.. I see that a patch that removes the

Re: [PATCH] slub: fix kernel BUG at mm/slub.c:1950!

2011-06-13 Thread Christoph Lameter
On Mon, 13 Jun 2011, Pekka Enberg wrote: > > Hmmm.. The allocpercpu in alloc_kmem_cache_cpus should take care of the > > alignment. Uhh.. I see that a patch that removes the #ifdef CMPXCHG_LOCAL > > was not applied? Pekka? > > This patch? > > http://git.kernel.org/?p=linux/kernel/git/penberg/slab-

Re: [PATCH] slub: fix kernel BUG at mm/slub.c:1950!

2011-06-13 Thread Christoph Lameter
On Sun, 12 Jun 2011, Hugh Dickins wrote: > 3.0-rc won't boot with SLUB on my PowerPC G5: kernel BUG at mm/slub.c:1950! > Bisected to 1759415e630e "slub: Remove CONFIG_CMPXCHG_LOCAL ifdeffery". > > After giving myself a medal for finding the BUG on line 1950 of mm/slub.c > (it's actually the >

[PATCH] slub: fix kernel BUG at mm/slub.c:1950!

2011-06-12 Thread Hugh Dickins
3.0-rc won't boot with SLUB on my PowerPC G5: kernel BUG at mm/slub.c:1950! Bisected to 1759415e630e "slub: Remove CONFIG_CMPXCHG_LOCAL ifdeffery". After giving myself a medal for finding the BUG on line 1950 of mm/slub.c (it's actually the VM_BUG_ON((unsigned long)(&pcp1) % (2 * sizeof(pc