Re: [PATCH] sched/membarrier: Fix redundant load of membarrier_state

2024-10-25 Thread Nysal Jan K.A.
On Fri, Oct 25, 2024 at 11:29:38AM +1100, Michael Ellerman wrote: > [To += Mathieu] > > "Nysal Jan K.A." writes: > > From: "Nysal Jan K.A" > > > > On architectures where ARCH_HAS_SYNC_CORE_BEFORE_USERMODE > > is not selected, sync_core_before_usermode() is a no-op. > > In membarrier_mm_sync_core

Re: [PATCH] sched/membarrier: Fix redundant load of membarrier_state

2024-10-25 Thread Mathieu Desnoyers
On 2024-10-24 20:29, Michael Ellerman wrote: [To += Mathieu] "Nysal Jan K.A." writes: From: "Nysal Jan K.A" On architectures where ARCH_HAS_SYNC_CORE_BEFORE_USERMODE is not selected, sync_core_before_usermode() is a no-op. In membarrier_mm_sync_core_before_usermode() the compiler does not el

Re: [PATCH] sched/membarrier: Fix redundant load of membarrier_state

2024-10-24 Thread Segher Boessenkool
Hi! On Fri, Oct 25, 2024 at 11:29:38AM +1100, Michael Ellerman wrote: > [To += Mathieu] > > "Nysal Jan K.A." writes: > > From: "Nysal Jan K.A" > > > > On architectures where ARCH_HAS_SYNC_CORE_BEFORE_USERMODE > > is not selected, sync_core_before_usermode() is a no-op. > > In membarrier_mm_sync

Re: [PATCH] sched/membarrier: Fix redundant load of membarrier_state

2024-10-24 Thread Stephen Rothwell
Hi Michael, On Fri, 25 Oct 2024 11:29:38 +1100 Michael Ellerman wrote: > > > diff --git a/include/linux/sched/mm.h b/include/linux/sched/mm.h > > index 07bb8d4181d7..042e60ab853a 100644 > > --- a/include/linux/sched/mm.h > > +++ b/include/linux/sched/mm.h > > @@ -540,6 +540,8 @@ enum { > > > >

Re: [PATCH] sched/membarrier: Fix redundant load of membarrier_state

2024-10-24 Thread Michael Ellerman
[To += Mathieu] "Nysal Jan K.A." writes: > From: "Nysal Jan K.A" > > On architectures where ARCH_HAS_SYNC_CORE_BEFORE_USERMODE > is not selected, sync_core_before_usermode() is a no-op. > In membarrier_mm_sync_core_before_usermode() the compiler does not > eliminate redundant branches and the lo

[PATCH] sched/membarrier: Fix redundant load of membarrier_state

2024-10-06 Thread Nysal Jan K.A.
From: "Nysal Jan K.A" On architectures where ARCH_HAS_SYNC_CORE_BEFORE_USERMODE is not selected, sync_core_before_usermode() is a no-op. In membarrier_mm_sync_core_before_usermode() the compiler does not eliminate redundant branches and the load of mm->membarrier_state for this case as the atomic