Re: [PATCH] rtc/rtc-opal: Disable rtc-alarms when opal doesn't support tpo

2015-07-07 Thread Michael Neuling
> [PATCH] rtc/rtc-opal: Disable rtc-alarms when opal doesn't support tpo I'd prefer to avoid the double negative and extra words. ie. rtc/opal: Enable alarms only when opal supports tpo But looks good other than that. Acked-by: Michael Neuling On Wed, 2015-06-03 at 10:21 +

Re: [PATCH] rtc/rtc-opal: Disable rtc-alarms when opal doesn't support tpo

2015-06-02 Thread Neelesh Gupta
On 06/03/2015 10:21 AM, Vaibhav Jain wrote: rtc-opal driver provides support for rtc alarms via times-power-on(tpo). However some platforms like BML use a fake rtc clock and don't support tpo. Such platforms are indicated by the missing 'has-tpo' property in the device tree. Current implementa

[PATCH] rtc/rtc-opal: Disable rtc-alarms when opal doesn't support tpo

2015-06-02 Thread Vaibhav Jain
rtc-opal driver provides support for rtc alarms via times-power-on(tpo). However some platforms like BML use a fake rtc clock and don't support tpo. Such platforms are indicated by the missing 'has-tpo' property in the device tree. Current implementation however enables callback for rtc_class_ops.