Re: [PATCH] random: vDSO: Redefine PAGE_SIZE and PAGE_MASK

2024-08-29 Thread Vincenzo Frascino
... >>> Without linux/array_size.h: >>> >>>    VDSO32C arch/powerpc/kernel/vdso/vgetrandom-32.o >>> In file included from : >>> /home/chleroy/linux-powerpc/lib/vdso/getrandom.c: In function >>> '__cvdso_getrandom_data': >>> /home/chleroy/linux-powerpc/lib/vdso/getrandom.c:89:40: error: implicit

Re: [PATCH] random: vDSO: Redefine PAGE_SIZE and PAGE_MASK

2024-08-29 Thread Christophe Leroy
Hi Vincenzo, Le 29/08/2024 à 14:01, Vincenzo Frascino a écrit : Hi Christophe, On 27/08/2024 18:14, Christophe Leroy wrote: Le 27/08/2024 à 18:05, Vincenzo Frascino a écrit : Hi Christophe, On 27/08/2024 11:49, Christophe Leroy wrote: ... ... Could you please clarify where minmax is

Re: [PATCH] random: vDSO: Redefine PAGE_SIZE and PAGE_MASK

2024-08-29 Thread Vincenzo Frascino
Hi Christophe, On 27/08/2024 18:38, LEROY Christophe wrote: > Hi Vicenzo, > > Le 27/08/2024 à 18:05, Vincenzo Frascino a écrit : >> Hi Christophe, >> >> On 27/08/2024 11:49, Christophe Leroy wrote: >> >> ... >> >> >> >> I agree with Arnd here. uapi/linux/mman.h can cause us problems in the long

Re: [PATCH] random: vDSO: Redefine PAGE_SIZE and PAGE_MASK

2024-08-29 Thread Vincenzo Frascino
Hi Christophe, On 27/08/2024 18:14, Christophe Leroy wrote: > > > Le 27/08/2024 à 18:05, Vincenzo Frascino a écrit : >> Hi Christophe, >> >> On 27/08/2024 11:49, Christophe Leroy wrote: >> >> ... ... >> >> Could you please clarify where minmax is needed? I tried to build Jason's >> master >>

Re: [PATCH] random: vDSO: Redefine PAGE_SIZE and PAGE_MASK

2024-08-27 Thread Vincenzo Frascino
Hi Christophe, On 27/08/2024 11:49, Christophe Leroy wrote: ... >> >> These are still two headers outside of the vdso/ namespace. For arm64 >> we had concluded that this is never safe, and any vdso header should >> only include other vdso headers so we never pull in anything that >> e.g. depend

Re: [PATCH] random: vDSO: Redefine PAGE_SIZE and PAGE_MASK

2024-08-27 Thread LEROY Christophe
Hi Vicenzo, Le 27/08/2024 à 18:05, Vincenzo Frascino a écrit : > Hi Christophe, > > On 27/08/2024 11:49, Christophe Leroy wrote: > > ... > > > > I agree with Arnd here. uapi/linux/mman.h can cause us problems in the long > run. > > I am attaching a patch to provide my view on how to minimiz

Re: [PATCH] random: vDSO: Redefine PAGE_SIZE and PAGE_MASK

2024-08-27 Thread Christophe Leroy
Le 27/08/2024 à 18:05, Vincenzo Frascino a écrit : Hi Christophe, On 27/08/2024 11:49, Christophe Leroy wrote: ... These are still two headers outside of the vdso/ namespace. For arm64 we had concluded that this is never safe, and any vdso header should only include other vdso headers so

Re: [PATCH] random: vDSO: Redefine PAGE_SIZE and PAGE_MASK

2024-08-27 Thread Christophe Leroy
Le 27/08/2024 à 11:59, Arnd Bergmann a écrit : On Tue, Aug 27, 2024, at 10:40, Jason A. Donenfeld wrote: I don't love this, but it might be the lesser of evils, so sure, let's do it. I think I'll combine these header fixups so that the whole operation is a bit more clear. The commit is still

Re: [PATCH] random: vDSO: Redefine PAGE_SIZE and PAGE_MASK

2024-08-27 Thread Arnd Bergmann
On Tue, Aug 27, 2024, at 10:40, Jason A. Donenfeld wrote: > I don't love this, but it might be the lesser of evils, so sure, let's > do it. > > I think I'll combine these header fixups so that the whole operation is > a bit more clear. The commit is still pretty small. Something like > below: > > F

Re: [PATCH] random: vDSO: Redefine PAGE_SIZE and PAGE_MASK

2024-08-27 Thread Christophe Leroy
Le 27/08/2024 à 10:40, Jason A. Donenfeld a écrit : I don't love this, but it might be the lesser of evils, so sure, let's do it. I don't love it either but I still prefer it to: #ifndef PAGE_SIZE #define PAGE_SIZE #define PAGE_MASK #endif At least we are sure that every architecture get t

Re: [PATCH] random: vDSO: Redefine PAGE_SIZE and PAGE_MASK

2024-08-27 Thread Jason A. Donenfeld
I don't love this, but it might be the lesser of evils, so sure, let's do it. I think I'll combine these header fixups so that the whole operation is a bit more clear. The commit is still pretty small. Something like below: >From 0d9a3d68cd6222395a605abd0ac625c41d4cabfa Mon Sep 17 00:00:00 2001 F

[PATCH] random: vDSO: Redefine PAGE_SIZE and PAGE_MASK

2024-08-27 Thread Christophe Leroy
Using PAGE_SIZE and PAGE_MASK in VDSO requires inclusion of page.h and it creates several problems, see commit 8b3843ae3634 ("vdso/datapage: Quick fix - use asm/page-def.h for ARM64") and commit cffaefd15a8f ("vdso: Use CONFIG_PAGE_SHIFT in vdso/datapage.h"). Redefine PAGE_SIZE and PAGE_MASK based