Re: [PATCH] qe_lib: Set gpio data before changing the direction to output

2009-08-18 Thread Michael Barkowski
Timur Tabi wrote: > Michael Barkowski wrote: > >> diff --git a/arch/powerpc/sysdev/qe_lib/gpio.c >> b/arch/powerpc/sysdev/qe_lib/gpio.c >> index 3485288..e7bf136 100644 >> --- a/arch/powerpc/sysdev/qe_lib/gpio.c >> +++ b/arch/powerpc/sysdev/qe_lib/gpio.c >> @@ -107,12 +107,11 @@ static int qe_gpi

[PATCH] qe_lib: Set gpio data before changing the direction to output

2009-08-18 Thread Michael Barkowski
This avoids having a short glitch if the desired initial value is not the same as what was previously in the data register. Signed-off-by: Michael Barkowski --- I can't think of a reason not to do this. The data register has no effect except when the pin is configured as an output, right? Pleas