Re: [PATCH] qe: miscellaneous code improvements and fixes to the QE library

2007-09-19 Thread Scott Wood
Timur Tabi wrote: > -void qe_setbrg(u32 brg, u32 rate) > +void qe_setbrg(unsigned int brg, unsigned int rate, unsigned int multiplier) > { > volatile u32 *bp; While you're at it, this should be __be32 __iomem *, no volatile. > +/* Configure the UCC to either Slow or Fast. > + * > + * A giv

[PATCH] qe: miscellaneous code improvements and fixes to the QE library

2007-09-19 Thread Timur Tabi
This patch makes numerous miscellaneous code improvements to the QE library. 1. Remove struct ucc_common and merge ucc_init_guemr() into ucc_set_type() (every caller of ucc_init_guemr() also calls ucc_set_type()). Modify all callers of ucc_set_type() accordingly. 2. Remove the unused enum