Re: [PATCH] ps3: remove driver_data direct access of struct device

2009-05-11 Thread Geoff Levand
Hi Roel, On 05/11/2009 12:34 PM, Roel Kluin wrote: > To avoid direct access to the driver_data pointer in struct device, the > functions dev_get_drvdata() and dev_set_drvdata() should be used. > > Signed-off-by: Roel Kluin > --- > Please review. especially note that I removed a > kfree(dev->sbd.

[PATCH] ps3: remove driver_data direct access of struct device

2009-05-11 Thread Roel Kluin
To avoid direct access to the driver_data pointer in struct device, the functions dev_get_drvdata() and dev_set_drvdata() should be used. Signed-off-by: Roel Kluin --- Please review. especially note that I removed a kfree(dev->sbd.core.driver_data); Is that correct? arch/powerpc/include/asm/p