Re: [PATCH] powerpc: make Freescale QE support a selectable Kconfig option

2008-10-03 Thread Kumar Gala
I think arch/powerpc/sysdev/qe_lib/Kconfig inclusion should be fixed. How about this patch? Or we can move QUICC_ENGINE into the qe_lib/Kconfig and include it in the platform/Kconfig... either way would work. Thanks for noticing. I want to leave the "hidden" options in qe_lib/Kconfig.. just mo

Re: [PATCH] powerpc: make Freescale QE support a selectable Kconfig option

2008-10-03 Thread Timur Tabi
On Fri, Oct 3, 2008 at 11:23 AM, Anton Vorontsov <[EMAIL PROTECTED]> wrote: > How about this patch? Or we can move QUICC_ENGINE into the > qe_lib/Kconfig and include it in the platform/Kconfig... either > way would work. > > Thanks for noticing. > > arch/powerpc/Kconfig |2 -- >

Re: [PATCH] powerpc: make Freescale QE support a selectable Kconfig option

2008-10-03 Thread Anton Vorontsov
Otherwise user-selectable options appears at the top level. Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> --- On Fri, Oct 03, 2008 at 11:09:09AM -0500, Timur Tabi wrote: > Anton Vorontsov wrote: > > > Yup. David said that platform GPIO controllers should not go into the > > drivers/gpio/, t

Re: [PATCH] powerpc: make Freescale QE support a selectable Kconfig option

2008-10-03 Thread Kumar Gala
On Oct 3, 2008, at 11:09 AM, Timur Tabi wrote: Anton Vorontsov wrote: Yup. David said that platform GPIO controllers should not go into the drivers/gpio/, their place is in the arch/. Then when I do "make menuconfig", why doesn't that option appear under "Platform support"? This is what

Re: [PATCH] powerpc: make Freescale QE support a selectable Kconfig option

2008-10-03 Thread Timur Tabi
Anton Vorontsov wrote: > Yup. David said that platform GPIO controllers should not go into the > drivers/gpio/, their place is in the arch/. Then when I do "make menuconfig", why doesn't that option appear under "Platform support"? This is what I see now: [*] Networking support ---> Device

Re: [PATCH] powerpc: make Freescale QE support a selectable Kconfig option

2008-10-03 Thread Anton Vorontsov
On Fri, Oct 03, 2008 at 10:43:50AM -0500, Timur Tabi wrote: > Anton Vorontsov wrote: > > > Btw, as for the need.. yes, it was needed to support the FHCI. But > > now the FHCI would just depend on it, which is better approach anyway. > > I also noticed that "QE GPIO support" is a top-level Kconfig

Re: [PATCH] powerpc: make Freescale QE support a selectable Kconfig option

2008-10-03 Thread Timur Tabi
Anton Vorontsov wrote: > Btw, as for the need.. yes, it was needed to support the FHCI. But > now the FHCI would just depend on it, which is better approach anyway. I also noticed that "QE GPIO support" is a top-level Kconfig option, instead of under Device Drivers -> GPIO. Is that intentional?

Re: [PATCH] powerpc: make Freescale QE support a selectable Kconfig option

2008-10-03 Thread Anton Vorontsov
On Fri, Oct 03, 2008 at 12:48:49PM +0400, Anton Vorontsov wrote: > On Fri, Oct 03, 2008 at 02:58:57AM -0500, Kumar Gala wrote: > > > > On Oct 3, 2008, at 2:04 AM, Anton Vorontsov wrote: > > > >> On Thu, Oct 02, 2008 at 10:27:57AM -0500, Timur Tabi wrote: > >>> Modify the Kconfig so that Freescale Q

Re: [PATCH] powerpc: make Freescale QE support a selectable Kconfig option

2008-10-03 Thread Anton Vorontsov
On Fri, Oct 03, 2008 at 02:58:57AM -0500, Kumar Gala wrote: > > On Oct 3, 2008, at 2:04 AM, Anton Vorontsov wrote: > >> On Thu, Oct 02, 2008 at 10:27:57AM -0500, Timur Tabi wrote: >>> Modify the Kconfig so that Freescale QUICC Engine (QE) support is a >>> selectable >>> option, thereby allowing u

Re: [PATCH] powerpc: make Freescale QE support a selectable Kconfig option

2008-10-03 Thread Kumar Gala
On Oct 3, 2008, at 2:04 AM, Anton Vorontsov wrote: On Thu, Oct 02, 2008 at 10:27:57AM -0500, Timur Tabi wrote: Modify the Kconfig so that Freescale QUICC Engine (QE) support is a selectable option, thereby allowing users to compile kernels without any QE support. The drawback is that QE s

Re: [PATCH] powerpc: make Freescale QE support a selectable Kconfig option

2008-10-03 Thread Anton Vorontsov
On Thu, Oct 02, 2008 at 10:27:57AM -0500, Timur Tabi wrote: > Modify the Kconfig so that Freescale QUICC Engine (QE) support is a selectable > option, thereby allowing users to compile kernels without any QE support. > > The drawback is that QE support is now disabled by default on platforms that

Re: [PATCH] powerpc: make Freescale QE support a selectable Kconfig option

2008-10-02 Thread Kumar Gala
On Oct 2, 2008, at 10:27 AM, Timur Tabi wrote: Modify the Kconfig so that Freescale QUICC Engine (QE) support is a selectable option, thereby allowing users to compile kernels without any QE support. The drawback is that QE support is now disabled by default on platforms that have a QE,

[PATCH] powerpc: make Freescale QE support a selectable Kconfig option

2008-10-02 Thread Timur Tabi
Modify the Kconfig so that Freescale QUICC Engine (QE) support is a selectable option, thereby allowing users to compile kernels without any QE support. The drawback is that QE support is now disabled by default on platforms that have a QE, and so a defconfig is needed to enable QE and QE devices