Re: [PATCH] powerpc: kernel: fix a refcount leak in format_show()

2022-03-01 Thread Hangyu Hua
Thanks. I will resubmit my patch latter. On 2022/3/2 03:50, Tyrel Datwyler wrote: On 3/1/22 04:55, Michael Ellerman wrote: Hangyu Hua writes: node needs to be dropped when of_property_read_string fails. So an earlier call to of_node_put is required here. That's true but ... diff --git a/a

Re: [PATCH] powerpc: kernel: fix a refcount leak in format_show()

2022-03-01 Thread Tyrel Datwyler
On 3/1/22 04:55, Michael Ellerman wrote: > Hangyu Hua writes: >> node needs to be dropped when of_property_read_string fails. So an earlier >> call >> to of_node_put is required here. > > That's true but ... > >> diff --git a/arch/powerpc/kernel/secvar-sysfs.c >> b/arch/powerpc/kernel/secvar-s

Re: [PATCH] powerpc: kernel: fix a refcount leak in format_show()

2022-03-01 Thread Michael Ellerman
Hangyu Hua writes: > node needs to be dropped when of_property_read_string fails. So an earlier > call > to of_node_put is required here. That's true but ... > diff --git a/arch/powerpc/kernel/secvar-sysfs.c > b/arch/powerpc/kernel/secvar-sysfs.c > index a0a78aba2083..cd0fa7028d86 100644 > ---

[PATCH] powerpc: kernel: fix a refcount leak in format_show()

2022-02-28 Thread Hangyu Hua
node needs to be dropped when of_property_read_string fails. So an earlier call to of_node_put is required here. Signed-off-by: Hangyu Hua --- arch/powerpc/kernel/secvar-sysfs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/secvar-sysfs.c b/arch/power