Re: [PATCH] powerpc: define the variable 'uaccess_flush' as static

2021-03-15 Thread heying (H)
Hello, 在 2021/3/15 17:16, Christophe Leroy 写道: I think W=1 will only report missing function prototypes. sparse also reports missing variables prototypes so that's better. All should be fixed. OK. I'll try to fix all the warnings in the file "arch/powerpc/kernel/setup_64.c" reported by sp

Re: [PATCH] powerpc: define the variable 'uaccess_flush' as static

2021-03-15 Thread Christophe Leroy
Le 15/03/2021 à 07:51, heying (H) a écrit : I think this is the case also for entry_flush. compiling with W=1 will tell you more. When I use these commands: make allmodconfig ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu- make C=2 arch/powerpc/kernel/setup_64.o ARCH=powerpc CROSS_COMPI

Re: [PATCH] powerpc: define the variable 'uaccess_flush' as static

2021-03-15 Thread heying (H)
I think this is the case also for entry_flush. compiling with W=1 will tell you more. When I use these commands: make allmodconfig ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu- make C=2 arch/powerpc/kernel/setup_64.o ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu- I find warnings as foll

[PATCH] powerpc: define the variable 'uaccess_flush' as static

2021-03-12 Thread He Ying
The variable 'uaccess_fulsh' is not referenced outside the file. Perhaps we should define it as static to avoid the warning as follows: arch/powerpc/kernel/setup_64.c:953:6: warning: symbol 'uaccess_flush' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: He Ying ---

Re: [PATCH] powerpc: define the variable 'uaccess_flush' as static

2021-03-12 Thread Cédric Le Goater
On 3/12/21 12:06 PM, He Ying wrote: > The variable 'uaccess_fulsh' is not referenced outside the file. Perhaps we > should define it as static to avoid the warning as follows: > > arch/powerpc/kernel/setup_64.c:953:6: warning: symbol 'uaccess_flush' > was not declared. Should it be static? > > Re