Re: [PATCH] powerpc: convert 'iommu_alloc failed' messages to dynamic debug

2016-08-03 Thread Mauricio Faria de Oliveira
On 08/03/2016 06:34 PM, Benjamin Herrenschmidt wrote: I think this is best done by the relevant community maintainer, I just threw an idea but I'm not that familiar with the details:-) Ok, sure; got it. Did you send them to the lkml list ? Yup, plus a few others lists from get_maintainer.pl

Re: [PATCH] powerpc: convert 'iommu_alloc failed' messages to dynamic debug

2016-08-03 Thread Benjamin Herrenschmidt
On Wed, 2016-08-03 at 16:39 -0300, Mauricio Faria de Oliveira wrote: > Hi Ben, > > On 06/13/2016 06:26 PM, Benjamin Herrenschmidt wrote: > > > > Another option would be to use a dma_attr for silencing mapping > > errors > > which NVME could use provided it does handle them gracefully ... > > I r

Re: [PATCH] powerpc: convert 'iommu_alloc failed' messages to dynamic debug

2016-08-03 Thread Mauricio Faria de Oliveira
Hi Ben, On 06/13/2016 06:26 PM, Benjamin Herrenschmidt wrote: Another option would be to use a dma_attr for silencing mapping errors which NVME could use provided it does handle them gracefully ... I recently submitted patches that implement your suggestion [1]. May you please review/comment i

Re: [PATCH] powerpc: convert 'iommu_alloc failed' messages to dynamic debug

2016-06-13 Thread Mauricio Faria de Oliveira
On 06/13/2016 06:51 PM, Benjamin Herrenschmidt wrote: Approximate wasn't a great choice of word but what I meant is: - The size doesn't mean you can do an allocation that size (pools layout etc..) - And it might be shared with another device (though less likely these days). Ah, yup - ok

Re: [PATCH] powerpc: convert 'iommu_alloc failed' messages to dynamic debug

2016-06-13 Thread Benjamin Herrenschmidt
On Mon, 2016-06-13 at 18:43 -0300, Mauricio Faria de Oliveira wrote: > Hi Ben, > > On 06/13/2016 06:26 PM, Benjamin Herrenschmidt wrote: > > I've been thinking about this a bit... it might be worthwhile adding > > a dma_* call to query the approximate size of the IOMMU window, as > > a way for the

Re: [PATCH] powerpc: convert 'iommu_alloc failed' messages to dynamic debug

2016-06-13 Thread Mauricio Faria de Oliveira
Hi Ben, On 06/13/2016 06:26 PM, Benjamin Herrenschmidt wrote: I've been thinking about this a bit... it might be worthwhile adding a dma_* call to query the approximate size of the IOMMU window, as a way for the device to adjust its requirements dynamically. Ok, cool; something like it was one

Re: [PATCH] powerpc: convert 'iommu_alloc failed' messages to dynamic debug

2016-06-13 Thread Benjamin Herrenschmidt
On Mon, 2016-06-13 at 10:27 -0300, Mauricio Faria de Oliveira wrote: > Hi Ben, > > On 06/11/2016 08:02 PM, Benjamin Herrenschmidt wrote: > > I'm not fan of this. This is a very useful message to diagnose why, > > for example, your network adapter is not working properly. > > > > A lot of drivers

Re: [PATCH] powerpc: convert 'iommu_alloc failed' messages to dynamic debug

2016-06-13 Thread Mauricio Faria de Oliveira
Hi Ben, On 06/11/2016 08:02 PM, Benjamin Herrenschmidt wrote: I'm not fan of this. This is a very useful message to diagnose why, for example, your network adapter is not working properly. A lot of drivers don't deal well with IOMMU errors. The fact that NVME trigger these is a problem that ne

Re: [PATCH] powerpc: convert 'iommu_alloc failed' messages to dynamic debug

2016-06-11 Thread Benjamin Herrenschmidt
On Fri, 2016-06-10 at 10:03 -0300, Mauricio Faria de Oliveira wrote: > This prevents flooding the logs with 'iommu_alloc failed' messages > while I/O is performed (normally) to very fast devices (e.g. NVMe). > > That error is not necessarily a problem; device drivers can retry > later / reschedule

[PATCH] powerpc: convert 'iommu_alloc failed' messages to dynamic debug

2016-06-10 Thread Mauricio Faria de Oliveira
This prevents flooding the logs with 'iommu_alloc failed' messages while I/O is performed (normally) to very fast devices (e.g. NVMe). That error is not necessarily a problem; device drivers can retry later / reschedule the requests for which the allocation failed, and handle things gracefully for