Re: [PATCH] powerpc: Inline setup_kup()

2020-12-15 Thread Michael Ellerman
Christophe Leroy writes: > Le 15/12/2020 à 02:42, Michael Ellerman a écrit : >> Christophe Leroy writes: >>> Le 14/12/2020 à 13:30, Michael Ellerman a écrit : setup_kup() is used by both 64-bit and 32-bit code. However on 64-bit it must not be __init, because it's used for CPU hotplug,

Re: [PATCH] powerpc: Inline setup_kup()

2020-12-14 Thread Christophe Leroy
Le 15/12/2020 à 02:42, Michael Ellerman a écrit : Christophe Leroy writes: Le 14/12/2020 à 13:30, Michael Ellerman a écrit : setup_kup() is used by both 64-bit and 32-bit code. However on 64-bit it must not be __init, because it's used for CPU hotplug, whereas on 32-bit it should be __init

Re: [PATCH] powerpc: Inline setup_kup()

2020-12-14 Thread Michael Ellerman
Christophe Leroy writes: > Le 14/12/2020 à 13:30, Michael Ellerman a écrit : >> setup_kup() is used by both 64-bit and 32-bit code. However on 64-bit >> it must not be __init, because it's used for CPU hotplug, whereas on >> 32-bit it should be __init because it calls setup_kuap/kuep() which >> ar

Re: [PATCH] powerpc: Inline setup_kup()

2020-12-14 Thread Christophe Leroy
Le 14/12/2020 à 13:30, Michael Ellerman a écrit : setup_kup() is used by both 64-bit and 32-bit code. However on 64-bit it must not be __init, because it's used for CPU hotplug, whereas on 32-bit it should be __init because it calls setup_kuap/kuep() which are __init. We worked around that pr

[PATCH] powerpc: Inline setup_kup()

2020-12-14 Thread Michael Ellerman
setup_kup() is used by both 64-bit and 32-bit code. However on 64-bit it must not be __init, because it's used for CPU hotplug, whereas on 32-bit it should be __init because it calls setup_kuap/kuep() which are __init. We worked around that problem in the past by marking it __ref, see commit 67d53