Re: [PATCH] powerpc: Force inlining of csum_add()

2021-06-17 Thread Michael Ellerman
On Tue, 11 May 2021 06:08:06 + (UTC), Christophe Leroy wrote: > Commit 328e7e487a46 ("powerpc: force inlining of csum_partial() to > avoid multiple csum_partial() with GCC10") inlined csum_partial(). > > Now that csum_partial() is inlined, GCC outlines csum_add() when > called by csum_partial(

Re: [PATCH] powerpc: Force inlining of csum_add()

2021-05-12 Thread Segher Boessenkool
On Wed, May 12, 2021 at 04:43:33PM +0200, Christophe Leroy wrote: > Le 12/05/2021 à 16:31, Segher Boessenkool a écrit : > >On Wed, May 12, 2021 at 02:56:56PM +0200, Christophe Leroy wrote: > >>Le 11/05/2021 à 12:51, Segher Boessenkool a écrit : > >>>Something seems to have decided this asm is more

Re: [PATCH] powerpc: Force inlining of csum_add()

2021-05-12 Thread Christophe Leroy
Le 12/05/2021 à 16:31, Segher Boessenkool a écrit : On Wed, May 12, 2021 at 02:56:56PM +0200, Christophe Leroy wrote: Le 11/05/2021 à 12:51, Segher Boessenkool a écrit : Something seems to have decided this asm is more expensive than it is. That isn't always avoidable -- the compiler cannot

Re: [PATCH] powerpc: Force inlining of csum_add()

2021-05-12 Thread Segher Boessenkool
On Wed, May 12, 2021 at 02:56:56PM +0200, Christophe Leroy wrote: > Le 11/05/2021 à 12:51, Segher Boessenkool a écrit : > >Something seems to have decided this asm is more expensive than it is. > >That isn't always avoidable -- the compiler cannot look inside asms -- > >but it seems it could be imp

Re: [PATCH] powerpc: Force inlining of csum_add()

2021-05-12 Thread Christophe Leroy
Hi, Le 11/05/2021 à 12:51, Segher Boessenkool a écrit : Hi! On Tue, May 11, 2021 at 06:08:06AM +, Christophe Leroy wrote: Commit 328e7e487a46 ("powerpc: force inlining of csum_partial() to avoid multiple csum_partial() with GCC10") inlined csum_partial(). Now that csum_partial() is inline

Re: [PATCH] powerpc: Force inlining of csum_add()

2021-05-11 Thread Segher Boessenkool
Hi! On Tue, May 11, 2021 at 06:08:06AM +, Christophe Leroy wrote: > Commit 328e7e487a46 ("powerpc: force inlining of csum_partial() to > avoid multiple csum_partial() with GCC10") inlined csum_partial(). > > Now that csum_partial() is inlined, GCC outlines csum_add() when > called by csum_par

[PATCH] powerpc: Force inlining of csum_add()

2021-05-10 Thread Christophe Leroy
Commit 328e7e487a46 ("powerpc: force inlining of csum_partial() to avoid multiple csum_partial() with GCC10") inlined csum_partial(). Now that csum_partial() is inlined, GCC outlines csum_add() when called by csum_partial(). c064fb28 : c064fb28: 7c 63 20 14 addcr3,r3,r4 c064fb2c: