Re: [PATCH] powerpc: Fix kobject memleak

2019-05-03 Thread Michael Ellerman
On Tue, 2019-04-30 at 01:09:23 UTC, "Tobin C. Harding" wrote: > Currently error return from kobject_init_and_add() is not followed by a > call to kobject_put(). This means there is a memory leak. > > Add call to kobject_put() in error path of kobject_init_and_add(). > > Signed-off-by: Tobin C. H

Re: [PATCH] powerpc: Fix kobject memleak

2019-04-30 Thread Tyrel Datwyler
On 04/29/2019 06:09 PM, Tobin C. Harding wrote: > Currently error return from kobject_init_and_add() is not followed by a > call to kobject_put(). This means there is a memory leak. > > Add call to kobject_put() in error path of kobject_init_and_add(). > > Signed-off-by: Tobin C. Harding > ---

Re: [PATCH] powerpc: Fix kobject memleak

2019-04-30 Thread Greg Kroah-Hartman
On Tue, Apr 30, 2019 at 11:09:23AM +1000, Tobin C. Harding wrote: > Currently error return from kobject_init_and_add() is not followed by a > call to kobject_put(). This means there is a memory leak. > > Add call to kobject_put() in error path of kobject_init_and_add(). > > Signed-off-by: Tobin

[PATCH] powerpc: Fix kobject memleak

2019-04-29 Thread Tobin C. Harding
Currently error return from kobject_init_and_add() is not followed by a call to kobject_put(). This means there is a memory leak. Add call to kobject_put() in error path of kobject_init_and_add(). Signed-off-by: Tobin C. Harding --- Untested, did not even build. Bad Tobin, no biscuit. No cal