Re: [PATCH] powerpc: Fix definition of SIAR register

2016-05-12 Thread Paul Mackerras
On Thu, May 12, 2016 at 09:27:40AM +0200, Thomas Huth wrote: > On 12.05.2016 06:57, Paul Mackerras wrote: > > On Mon, Apr 25, 2016 at 10:15:47AM +0200, Alexander Graf wrote: > >> > +#define SPRN_SIAR796 > >> > >> I'm sure there's a reason (iSeries?) we used the r/o version before. > >> Be

Re: [PATCH] powerpc: Fix definition of SIAR register

2016-05-12 Thread Thomas Huth
On 12.05.2016 06:57, Paul Mackerras wrote: > On Mon, Apr 25, 2016 at 10:15:47AM +0200, Alexander Graf wrote: >> +#define SPRN_SIAR796 >> >> I'm sure there's a reason (iSeries?) we used the r/o version before. Better >> introduce a new constant that gives us rw access and use that in the k

Re: [PATCH] powerpc: Fix definition of SIAR register

2016-05-11 Thread Paul Mackerras
On Mon, Apr 25, 2016 at 10:15:47AM +0200, Alexander Graf wrote: > > >> +#define SPRN_SIAR796 > > I'm sure there's a reason (iSeries?) we used the r/o version before. Better > introduce a new constant that gives us rw access and use that in the kvm > entry/exit code. I don't think we ever d

Re: [PATCH] powerpc: Fix definition of SIAR register

2016-05-11 Thread Paul Mackerras
On Fri, Apr 08, 2016 at 05:54:11PM +0200, Thomas Huth wrote: > The SIAR register is available twice, one time as SPR 780 (unprivileged, > but read-only), and one time as SPR 796 (privileged, but read and write). > The Linux kernel code currently uses SPR 780 - and while this is OK for > reading, wr

Re: [PATCH] powerpc: Fix definition of SIAR register

2016-04-25 Thread Madhavan Srinivasan
On Monday 25 April 2016 01:45 PM, Alexander Graf wrote: > >> Am 25.04.2016 um 10:08 schrieb Madhavan Srinivasan >> : >> >> >> >>> On Friday 08 April 2016 09:24 PM, Thomas Huth wrote: >>> The SIAR register is available twice, one time as SPR 780 (unprivileged, >>> but read-only), and one time as

Re: [PATCH] powerpc: Fix definition of SIAR register

2016-04-25 Thread Alexander Graf
On 04/25/2016 11:16 AM, Thomas Huth wrote: On 25.04.2016 10:15, Alexander Graf wrote: Am 25.04.2016 um 10:08 schrieb Madhavan Srinivasan : On Friday 08 April 2016 09:24 PM, Thomas Huth wrote: The SIAR register is available twice, one time as SPR 780 (unprivileged, but read-only), and one t

Re: [PATCH] powerpc: Fix definition of SIAR register

2016-04-25 Thread Thomas Huth
On 25.04.2016 10:15, Alexander Graf wrote: > > >> Am 25.04.2016 um 10:08 schrieb Madhavan Srinivasan >> : >> >> >> >>> On Friday 08 April 2016 09:24 PM, Thomas Huth wrote: >>> The SIAR register is available twice, one time as SPR 780 (unprivileged, >>> but read-only), and one time as SPR 796 (pr

Re: [PATCH] powerpc: Fix definition of SIAR register

2016-04-25 Thread Alexander Graf
> Am 25.04.2016 um 10:08 schrieb Madhavan Srinivasan : > > > >> On Friday 08 April 2016 09:24 PM, Thomas Huth wrote: >> The SIAR register is available twice, one time as SPR 780 (unprivileged, >> but read-only), and one time as SPR 796 (privileged, but read and write). >> The Linux kernel code

Re: [PATCH] powerpc: Fix definition of SIAR register

2016-04-25 Thread Madhavan Srinivasan
On Friday 08 April 2016 09:24 PM, Thomas Huth wrote: > The SIAR register is available twice, one time as SPR 780 (unprivileged, > but read-only), and one time as SPR 796 (privileged, but read and write). > The Linux kernel code currently uses SPR 780 - and while this is OK for > reading, writing

Re: [PATCH] powerpc: Fix definition of SIAR register

2016-04-24 Thread Thomas Huth
On 08.04.2016 17:54, Thomas Huth wrote: > The SIAR register is available twice, one time as SPR 780 (unprivileged, > but read-only), and one time as SPR 796 (privileged, but read and write). > The Linux kernel code currently uses SPR 780 - and while this is OK for > reading, writing to that registe

[PATCH] powerpc: Fix definition of SIAR register

2016-04-08 Thread Thomas Huth
The SIAR register is available twice, one time as SPR 780 (unprivileged, but read-only), and one time as SPR 796 (privileged, but read and write). The Linux kernel code currently uses SPR 780 - and while this is OK for reading, writing to that register of course does not work. Since the KVM code tr